From a1cb3b7845569e4194a2fcae4af7bf9e45aefe6d Mon Sep 17 00:00:00 2001
From: llaffont <llaffont@afi-sa.fr>
Date: Fri, 18 Nov 2016 17:03:46 +0100
Subject: [PATCH] hackfest search domains: remove label on domain select
---
library/ZendAfi/View/Helper/TagRechercheSimple.php | 14 +++++---------
.../ZendAfi/View/Helper/TagRechercheSimpleTest.php | 10 ----------
2 files changed, 5 insertions(+), 19 deletions(-)
diff --git a/library/ZendAfi/View/Helper/TagRechercheSimple.php b/library/ZendAfi/View/Helper/TagRechercheSimple.php
index cd5e8f3050e..64915c5f866 100644
--- a/library/ZendAfi/View/Helper/TagRechercheSimple.php
+++ b/library/ZendAfi/View/Helper/TagRechercheSimple.php
@@ -189,15 +189,11 @@ class ZendAfi_View_Helper_TagRechercheSimple extends Zend_View_Helper_HtmlElemen
protected function _renderDomainSelectAsSelect($domains) {
$domains = [0 => $this->view->_('Partout')] + $domains;
- return $this->view->tag('div',
- $this->view->tag('label',
- $this->view->_('Rechercher dans le domaine'),
- ['for' => 'facettes'])
- . $this->view->formSelect(
- 'facettes',
- 0,
- [],
- $domains));
+ return $this->view->formSelect(
+ 'facettes',
+ 0,
+ ['title' => $this->view->_('Domaine de recherche')],
+ $domains);
}
diff --git a/tests/library/ZendAfi/View/Helper/TagRechercheSimpleTest.php b/tests/library/ZendAfi/View/Helper/TagRechercheSimpleTest.php
index c1974d3218b..fdd6a40b1a1 100644
--- a/tests/library/ZendAfi/View/Helper/TagRechercheSimpleTest.php
+++ b/tests/library/ZendAfi/View/Helper/TagRechercheSimpleTest.php
@@ -113,16 +113,6 @@ class ZendAfi_View_Helper_TagRechercheSimpleDefaultTest extends ViewHelperTestCa
}
- /**
- * @depends withDomainSelectInputShouldBePresent
- * @test
- */
- public function domainSelectLabelShouldBePrensent($html) {
- $this->assertXPath($html,
- '//div/label[@for="facettes"][following-sibling::select[@name="facettes"]/option[1][@value="0"][@selected="selected"]]');
- }
-
-
/**
* @depends withDomainSelectInputShouldBePresent
* @test
--
GitLab