From a478c8cf74cc2b3a59a75bbc57774f3938fe2cac Mon Sep 17 00:00:00 2001
From: Arthur Suzuki <arthur.suzuki@biblibre.com>
Date: Tue, 17 Aug 2021 11:13:35 +0200
Subject: [PATCH] hotline#127891 : fix wrong icon in newsletter dashboard
---
VERSIONS_HOTLINE/127891 | 1 +
library/ZendAfi/Controller/Plugin/Manager/Newsletter.php | 2 +-
.../modules/admin/controllers/NewsletterControllerTest.php | 6 ++++++
3 files changed, 8 insertions(+), 1 deletion(-)
create mode 100644 VERSIONS_HOTLINE/127891
diff --git a/VERSIONS_HOTLINE/127891 b/VERSIONS_HOTLINE/127891
new file mode 100644
index 00000000000..fb516dd2e3e
--- /dev/null
+++ b/VERSIONS_HOTLINE/127891
@@ -0,0 +1 @@
+ - ticket #127891 : Lettres d'informations : Remplacement d'une icone erronée dans le tableau de bord.
\ No newline at end of file
diff --git a/library/ZendAfi/Controller/Plugin/Manager/Newsletter.php b/library/ZendAfi/Controller/Plugin/Manager/Newsletter.php
index a5d3a8ae966..4bbe041a407 100644
--- a/library/ZendAfi/Controller/Plugin/Manager/Newsletter.php
+++ b/library/ZendAfi/Controller/Plugin/Manager/Newsletter.php
@@ -32,7 +32,7 @@ class ZendAfi_Controller_Plugin_Manager_Newsletter extends ZendAfi_Controller_Pl
'icon' => 'edit',
'label' => $this->_('Modifier la newsletter')],
['url' => '/admin/newsletter/preview/id/%s',
- 'icon' => 'show',
+ 'icon' => 'view',
'label' => $this->_('Visualiser la newsletter')],
['url' => '/admin/newsletter/edit-subscribers/id/%s',
'icon' => 'users',
diff --git a/tests/application/modules/admin/controllers/NewsletterControllerTest.php b/tests/application/modules/admin/controllers/NewsletterControllerTest.php
index 8a32e205978..ee6431bf491 100644
--- a/tests/application/modules/admin/controllers/NewsletterControllerTest.php
+++ b/tests/application/modules/admin/controllers/NewsletterControllerTest.php
@@ -159,6 +159,12 @@ class Admin_NewsletterControllerIndexActionTest extends Admin_NewsletterControll
}
+ /** @test */
+ public function testPreviewLinkShouldHaveViewIcon() {
+ $this->assertXPath("//a/img[@class='ico'][contains(@src,'view')]");
+ }
+
+
public function testDuplicateLink() {
$this->assertXPath("//a[contains(@href, '/admin/newsletter/duplicate/id/1')]");
}
--
GitLab