diff --git a/library/ZendAfi/View/Helper/Redmine/Header.php b/library/ZendAfi/View/Helper/Redmine/Header.php index ac61af22f15eccff375422640247c41edcb8edc4..ab8abaa2e86eed979d2e827dce25a7cdebbb92be 100644 --- a/library/ZendAfi/View/Helper/Redmine/Header.php +++ b/library/ZendAfi/View/Helper/Redmine/Header.php @@ -106,8 +106,8 @@ class ZendAfi_View_Helper_Redmine_Header extends ZendAfi_View_Helper_BaseHelper ->setUrl($this->view->url(['module' => 'admin', 'controller' => 'bib', 'action' => 'edit', - 'backUrl' => $this->view->url(), - 'id' => $library->getId()], null ,true) . '#fieldset-redmine') + 'id' => $library->getId(), + 'backUrl' => $this->view->url()], null ,true) . '#fieldset-redmine') ->setAttribs(['class' => 'library_redmine_account', 'title' => $title])); } diff --git a/tests/application/modules/admin/controllers/AccueilControllerCmsTest.php b/tests/application/modules/admin/controllers/AccueilControllerCmsTest.php index f6c23dd0fe05ee224aa24d7fdb9e902ed43cefa2..0d43207883697e6c0830a346b47fa0a8a15ed3b6 100644 --- a/tests/application/modules/admin/controllers/AccueilControllerCmsTest.php +++ b/tests/application/modules/admin/controllers/AccueilControllerCmsTest.php @@ -245,7 +245,7 @@ class Admin_AccueilControllerCmsDispatchWithConfigAdminTest extends Admin_Abstra /** @test */ public function backButtonShouldContainsOnclickGoToIndex() { - $this->assertXPathContentContains('//div//button[@class="admin-button back"][@data-url="/admin/accueil"][contains(@onclick, "/admin/accueil")]', 'Retour'); + $this->assertXPathContentContains('//div//button[@class="back admin-button"][@data-url="/admin/accueil"][contains(@onclick, "/admin/accueil")]', 'Retour'); } } diff --git a/tests/application/modules/admin/controllers/AdminIndexControllerTest.php b/tests/application/modules/admin/controllers/AdminIndexControllerTest.php index 912ecabd81a4a62f09b04961351cee3b27338135..dbf321caf11d5b990d28c4fa0459dfe19bb39363 100644 --- a/tests/application/modules/admin/controllers/AdminIndexControllerTest.php +++ b/tests/application/modules/admin/controllers/AdminIndexControllerTest.php @@ -608,7 +608,7 @@ class AdminIndexControllerAdminVarEditDilicomPnbIpAdressesTest extends AdminInde /** @test */ public function backUrlShouldBeAdminVar() { - $this->assertXPath('//div//button[@class="admin-button back"][contains(@onclick, "/admin/index/adminvar")]'); + $this->assertXPath('//div//button[@class="back admin-button"][contains(@onclick, "/admin/index/adminvar")]'); } } diff --git a/tests/application/modules/admin/controllers/AlbumControllerListViewModeTest.php b/tests/application/modules/admin/controllers/AlbumControllerListViewModeTest.php index df46e35688d387dc1a0c3b04a58e3c4ff74fb373..7c24052205645092d32ea0ecd84eb417ae3a78cf 100644 --- a/tests/application/modules/admin/controllers/AlbumControllerListViewModeTest.php +++ b/tests/application/modules/admin/controllers/AlbumControllerListViewModeTest.php @@ -292,7 +292,7 @@ class AlbumControllerListModeEditWithPaginationTest /** @test */ public function backShouldContainsPage34() { - $this->assertXPathContentContains('//div//button[@class="admin-button back"][contains(@onclick, "/page/34")][contains(@data-url, "/page/34")]', 'Retour'); + $this->assertXPathContentContains('//div//button[@class="back admin-button"][contains(@onclick, "/page/34")][contains(@data-url, "/page/34")]', 'Retour'); } } diff --git a/tests/application/modules/admin/controllers/AlbumControllerTest.php b/tests/application/modules/admin/controllers/AlbumControllerTest.php index c882b834fa45ba6ece7dc06658fc6f2530f3ac3d..50728d4d77172462f2a7d6c6c6ce7ce5d57df403 100644 --- a/tests/application/modules/admin/controllers/AlbumControllerTest.php +++ b/tests/application/modules/admin/controllers/AlbumControllerTest.php @@ -373,7 +373,7 @@ class Admin_AlbumControllerAddCategorieToFavorisTest extends Admin_AlbumControll /** @test */ public function shouldHaveBackButton() { - $this->assertXPathContentContains('//div//button[@class="admin-button back"][contains(@onclick, "admin/album/index/id/2/cat_id/2")]', "Retour"); + $this->assertXPathContentContains('//div//button[@class="back admin-button"][contains(@onclick, "admin/album/index/id/2/cat_id/2")]', "Retour"); } } @@ -533,7 +533,7 @@ class Admin_AlbumControllerEditCategorieFavorisTest extends Admin_AlbumControlle /** @test */ public function backButtonShouldContainsCatId() { - $this->assertXPath('//div//button[@class="admin-button back"][contains(@onclick, "admin/album/index/id/2/cat_id/2")]'); + $this->assertXPath('//div//button[@class="back admin-button"][contains(@onclick, "admin/album/index/id/2/cat_id/2")]'); } } @@ -2614,9 +2614,8 @@ class Admin_AlbumControllerImportEADTest extends Admin_AlbumControllerTestCase { /** @test */ public function pageShouldHaveLinkToExportEAD() { - $this->assertXPathContentContains('//a[@href="/admin/album/export-ead"]',"Exporter en EAD",$this->_response->getBody()); + $this->assertXPathContentContains('//button[contains(@onclick, "/admin/album/export-ead")]',"Exporter en EAD"); } - } diff --git a/tests/application/modules/admin/controllers/BatchControllerTest.php b/tests/application/modules/admin/controllers/BatchControllerTest.php index e39f42ff8ecec6870ced5073067334debcc36371..9c58db55981bccd7fd11d09bc34225d67ec1fd07 100644 --- a/tests/application/modules/admin/controllers/BatchControllerTest.php +++ b/tests/application/modules/admin/controllers/BatchControllerTest.php @@ -75,7 +75,7 @@ class BatchControllerWithBatchInDb extends BatchControllerTestCase { /** @test */ public function buttonShouldLinkToAdd() { - $this->assertXPath('//div[contains(@onclick, "batch/add")]'); + $this->assertXPath('//button[contains(@onclick, "batch/add")]'); } diff --git a/tests/application/modules/admin/controllers/BibControllerTest.php b/tests/application/modules/admin/controllers/BibControllerTest.php index bf0dd4dc2ed4c4831cfbf8aeb807caf83cf3c4be..734e4bd64b6f40526023c1af09b98e738d4040c1 100644 --- a/tests/application/modules/admin/controllers/BibControllerTest.php +++ b/tests/application/modules/admin/controllers/BibControllerTest.php @@ -130,7 +130,7 @@ class BibControllerIndexWidthAdminPortailTest extends BibControllerTestCase { /** @test */ public function pageShouldContainsAddLibraryLink() { - $this->assertXPathContentContains('//div[contains(@onclick, "/admin/bib/add")]', 'Ajouter une bibliothèque'); + $this->assertXPathContentContains('//button[contains(@onclick, "/admin/bib/add")]', 'Ajouter une bibliothèque'); } @@ -1692,12 +1692,6 @@ class BibControllerWithRemineAPITest extends BibControllerWithRedmineAPITestCase public function redmineApiKeyShouldBeEmpty() { $this->assertXPath('//table//tr//td//input[@name="redmine_api_key"][@value=""][@type="password"]', $this->_response->getBody()); } - - - /** @test */ - public function anchorRedmineShouldBePresent() { - $this->assertXPath('//form//a[@name="redmine"]'); - } } diff --git a/tests/application/modules/admin/controllers/CatalogueControllerTest.php b/tests/application/modules/admin/controllers/CatalogueControllerTest.php index c17fc5b08b4e506d553491f66ee771b8cfac03d9..69b382168da57af4539a3ddf8e69697799a969f5 100644 --- a/tests/application/modules/admin/controllers/CatalogueControllerTest.php +++ b/tests/application/modules/admin/controllers/CatalogueControllerTest.php @@ -532,7 +532,7 @@ class CatalogueControllerWithAModoBibWithRightAccesDomainesIndexTest extends Adm /** @test */ public function pageShouldContainsButtonAdd() { - $this->assertXPath('//div[contains(@onclick, "catalogue/add")]'); + $this->assertXPath('//button[contains(@onclick, "catalogue/add")]'); } @@ -618,7 +618,7 @@ class CatalogueControllerActionTesterTest extends AbstractControllerTestCase { /** @test */ public function modifyLinkShouldContainsSlashes() { - $this->assertXPathContentContains('//a[contains(@href, "/admin/catalogue/edit/id_catalogue/6")]', "Modifier la définition du catalogue"); + $this->assertXPathContentContains('//button[contains(@onclick, "/admin/catalogue/edit/id_catalogue/6")]', "Modifier le catalogue"); } } @@ -680,12 +680,6 @@ class CatalogueControllerEditCatalogueTest extends AdminCatalogueControllerTestC } - /** @test **/ - public function scriptControlMajShouldBePresent() { - $this->assertXPath('//script[contains(@src,"/admin/js/controle_maj")]'); - } - - /** @test */ public function inputLibelleShouldContainsAdultes() { $this->assertXPath('//input[@name="libelle"][@value="Adultes"]'); @@ -816,7 +810,7 @@ class CatalogueControllerEditCatalogueInPopupTest extends AdminCatalogueControll public function boutonRetourShouldCloseThePopup() { $xpath = new Storm_Test_XPath(); $xpath->assertXPath($this->_json->content, - '//div[@class="bouton"][contains(@onclick, "opacDialogClose")][not(contains(@onclick, "window.replace"))]'); + '//button[contains(@onclick, "opacDialogClose")][not(contains(@onclick, "window.replace"))]'); } } @@ -1014,12 +1008,6 @@ class CatalogueControllerAddCatalogueTest extends AdminCatalogueControllerTestCa } - /** @test **/ - public function scriptControlMajShouldBePresent() { - $this->assertXPath('//script[contains(@src,"/admin/js/controle_maj")]'); - } - - /** @test */ public function inputLibelleShouldContainsNouveauCatalogue() { $this->assertXPath('//input[@name="libelle"][@value="** nouveau domaine **"]'); @@ -1039,12 +1027,6 @@ class CatalogueControllerAddCatalogueTest extends AdminCatalogueControllerTestCa public function formActionShouldBeAdminCatalogueAddIdCatalogue100() { $this->assertXPath('//form[contains(@action, "/admin/catalogue/add/id_catalogue/100")]'); } - - - /** @test */ - public function catalogueAddFormShouldContainsJsControleMaj() { - $this->assertXPath('//script[contains(@src,"controle_maj")]'); - } } diff --git a/tests/application/modules/admin/controllers/CmsCategoryControllerTest.php b/tests/application/modules/admin/controllers/CmsCategoryControllerTest.php index 0637a87a360381e6b70e91ce35ad246962e29407..1a91728791ce28c6ffc74d0a1d3668ed908ecae5 100644 --- a/tests/application/modules/admin/controllers/CmsCategoryControllerTest.php +++ b/tests/application/modules/admin/controllers/CmsCategoryControllerTest.php @@ -354,7 +354,7 @@ class CmsCategoryControllerEditActionPermissionsTest extends CmsCategoryControll /** @test */ public function permissionsSubmitButtonShouldBePresent() { - $this->assertXPath('//form[contains(@action, "cms-category/permissions/id/23")]//div[@id="menu_itemperms23"]'); + $this->assertXPath('//form[contains(@action, "cms-category/permissions/id/23")]//button[@type="submit"]'); } diff --git a/tests/application/modules/admin/controllers/CmsControllerListModeTest.php b/tests/application/modules/admin/controllers/CmsControllerListModeTest.php index 46c2b363b20830be5761636f43aa40bd21534ef6..c7264ffd430ecedaa910d4c358dd0299d360e582 100644 --- a/tests/application/modules/admin/controllers/CmsControllerListModeTest.php +++ b/tests/application/modules/admin/controllers/CmsControllerListModeTest.php @@ -388,7 +388,7 @@ class CmsControllerListModeEditWithPaginationTest /** @test */ public function backShouldContainPage34() { - $this->assertXPath('//div//button[@class="admin-button back"][contains(@onclick, "/page/34")]'); + $this->assertXPath('//div//button[@class="back admin-button"][contains(@onclick, "/page/34")]'); } } diff --git a/tests/application/modules/admin/controllers/CmsControllerTest.php b/tests/application/modules/admin/controllers/CmsControllerTest.php index 82e23040c6aeda38664062ef3820f4bc97a94b67..5ac1329b80ba273e89fd00a2d9be2f20d6a72f86 100644 --- a/tests/application/modules/admin/controllers/CmsControllerTest.php +++ b/tests/application/modules/admin/controllers/CmsControllerTest.php @@ -795,7 +795,7 @@ class CmsControllerArticleConcertEditRenderPopupActionTest extends CmsController /** @test */ public function boutonRetourShouldCloseThePopup() { $this->_xpath->assertXPath($this->_json->content, - '//div//button[@class="admin-button back"][contains(@onclick, "opacDialogClose")][not(contains(@onclick, "window.replace"))][text()="Fermer"]'); + '//div//button[@class="back admin-button"][contains(@onclick, "opacDialogClose")][not(contains(@onclick, "window.replace"))][text()="Fermer"]'); } @@ -836,7 +836,7 @@ class CmsControllerArticleConcertEditRenderPopupActionTest extends CmsController /** @test */ public function boutonValiderShouldSubmitFormUsingAjax() { $this->_xpath->assertXPath($this->_json->content, - '//div//button[@class="admin-button validate"][contains(@onclick, "initializeAjaxFormSubmit")]'); + '//div//button[@class="validate admin-button"][contains(@onclick, "initializeAjaxFormSubmit")]'); } @@ -1242,14 +1242,14 @@ class CmsControllerArticleConcertEditActionPostWithWrongDataRenderPopupTest exte /** @test */ public function boutonValiderShouldSubmitFormUsingAjax() { $this->_xpath->assertXPath($this->_json->content, - '//div//button[@class="admin-button validate"][contains(@onclick, "initializeAjaxFormSubmit")]'); + '//div//button[@class="validate admin-button"][contains(@onclick, "initializeAjaxFormSubmit")]'); } /** @test */ public function cancelButtonShouldReloadPopup() { $this->_xpath->assertXPath($this->_json->content, - '//div//button[@class="admin-button undo"][@data-popup="true"][not(contains(@onclick, "/admin/cms/edit/id/4"))][not(contains(@onclick, "render/popup"))][@data-url= "/admin/cms/edit/id/4"]'); + '//div//button[@class="undo admin-button"][@data-popup="true"][not(contains(@onclick, "/admin/cms/edit/id/4"))][not(contains(@onclick, "render/popup"))][@data-url= "/admin/cms/edit/id/4"]'); } diff --git a/tests/application/modules/admin/controllers/CustomFieldsControllerTest.php b/tests/application/modules/admin/controllers/CustomFieldsControllerTest.php index dfcce54a74cc6056764defd9ccaf1ed091bb7a2e..a5e16fce6721ac2d53f002b9092d5e370f3598eb 100644 --- a/tests/application/modules/admin/controllers/CustomFieldsControllerTest.php +++ b/tests/application/modules/admin/controllers/CustomFieldsControllerTest.php @@ -175,7 +175,7 @@ class CustomFieldsControllerIndexTest extends CustomFieldControllerTestCase { /** @test */ public function linkToManageCustomFieldsShouldBePresent() { - $this->assertXPathContentContains('//div[contains(@onclick, "/admin/custom-fields-meta")]//td', 'Types de champs personnalisés'); + $this->assertXPathContentContains('//button[contains(@onclick, "/admin/custom-fields-meta")]', 'Types de champs personnalisés'); } diff --git a/tests/application/modules/admin/controllers/CustomFieldsMetaControllerTest.php b/tests/application/modules/admin/controllers/CustomFieldsMetaControllerTest.php index f38a7ea32e075bd10cff1fa98a4915e1e7b0aaed..db2b793fb6ce04cc4a02c2de7f600423b16da948 100644 --- a/tests/application/modules/admin/controllers/CustomFieldsMetaControllerTest.php +++ b/tests/application/modules/admin/controllers/CustomFieldsMetaControllerTest.php @@ -116,14 +116,14 @@ class CustomFieldsMetaControllerIndexActionTest extends CustomFieldsMetaControll /** @test */ public function linkToAddNewShouldBePresent() { - $this->assertXPathContentContains('//div[contains(@onclick, "/admin/custom-fields-meta/add")]//td', + $this->assertXPathContentContains('//button[contains(@onclick, "/admin/custom-fields-meta/add")]', 'Nouveau type de champ'); } /** @test */ public function backToCustomFieldsLinkShouldBePresent() { - $this->assertXPathContentContains('//div[contains(@onclick, "/admin/custom-fields\'")]', + $this->assertXPathContentContains('//button[contains(@onclick, "/admin/custom-fields\'")]', 'Retour à la liste'); } } diff --git a/tests/application/modules/admin/controllers/CustomFieldsReportControllerTest.php b/tests/application/modules/admin/controllers/CustomFieldsReportControllerTest.php index 0cf9b21cbc2cafe1f2947a0f5ce838082a0ebf46..5f0503bb5cdd721bc8ab80e8dd512f37c543a8ba 100644 --- a/tests/application/modules/admin/controllers/CustomFieldsReportControllerTest.php +++ b/tests/application/modules/admin/controllers/CustomFieldsReportControllerTest.php @@ -43,7 +43,7 @@ class CustomFieldsReportControllerAddTest extends AbstractControllerTestCase { /** @test */ public function pageShouldContainsGenerateReportButton() { - $this->assertXPathContentContains('//div[@id="menu_itemgenerate"]//td', 'Générer'); + $this->assertXPathContentContains('//button', 'Générer'); } diff --git a/tests/application/modules/admin/controllers/FrbrLinkControllerTest.php b/tests/application/modules/admin/controllers/FrbrLinkControllerTest.php index 4d0e0277a097f3bbf792646535fe4bbacc630d0c..dd0dfbd029e0a36abea3a64a537e3f8cc5512a72 100644 --- a/tests/application/modules/admin/controllers/FrbrLinkControllerTest.php +++ b/tests/application/modules/admin/controllers/FrbrLinkControllerTest.php @@ -151,13 +151,13 @@ class Admin_FrbrLinkControllerIndexTest extends Admin_FrbrLinkControllerTestCase /** @test */ public function linkToAddNewShouldBePresent() { - $this->assertXPath('//div[contains(@onclick, "frbr-link/add")]'); + $this->assertXPath('//button[contains(@onclick, "frbr-link/add")]'); } /** @test */ public function linkToManageTypesShouldBePresent() { - $this->assertXPath('//div[contains(@onclick, "frbr-linktype")]'); + $this->assertXPath('//button[contains(@onclick, "frbr-linktype")]'); } } diff --git a/tests/application/modules/admin/controllers/FrbrLinktypeControllerTest.php b/tests/application/modules/admin/controllers/FrbrLinktypeControllerTest.php index 07a2f80d153fcb3bbdc53349651c0be315327c79..a3d61aa2e2ee735d2d75d73cb67e1d3a95c889fe 100644 --- a/tests/application/modules/admin/controllers/FrbrLinktypeControllerTest.php +++ b/tests/application/modules/admin/controllers/FrbrLinktypeControllerTest.php @@ -16,7 +16,7 @@ * * You should have received a copy of the GNU AFFERO GENERAL PUBLIC LICENSE * along with BOKEH; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ require_once 'AdminAbstractControllerTestCase.php'; @@ -58,7 +58,7 @@ class Admin_FrbrLinktypeControllerIndexTest extends Admin_FrbrLinktypeController /** @test */ public function firstRowTDShouldContainsVousAimerezAussi() { - $this->assertXPathContentContains('//tbody//tr[1]//td', 'Vous aimerez aussi',$this->response->getBody()); + $this->assertXPathContentContains('//tbody//tr[1]//td', 'Vous aimerez aussi',$this->response->getBody()); } @@ -70,7 +70,7 @@ class Admin_FrbrLinktypeControllerIndexTest extends Admin_FrbrLinktypeController /** @test */ public function firstRowTDShouldContainsVousAimerezAussiB() { - $this->assertXPathContentContains('//tbody//tr[1]//td', 'vous aimerez aussi B'); + $this->assertXPathContentContains('//tbody//tr[1]//td', 'vous aimerez aussi B'); } @@ -94,13 +94,13 @@ class Admin_FrbrLinktypeControllerIndexTest extends Admin_FrbrLinktypeController /** @test */ public function linkToAddNewShouldBePresent() { - $this->assertXPath('//div[contains(@onclick, "frbr-linktype/add")]'); + $this->assertXPath('//button[contains(@onclick, "frbr-linktype/add")]'); } /** @test */ public function linkToManageLinksShouldBePresent() { - $this->assertXPath('//div[contains(@onclick, "frbr-link\')")]'); + $this->assertXPath('//button[contains(@onclick, "admin/frbr-link")]'); } } @@ -136,7 +136,7 @@ class Admin_FrbrLinktypeControllerEditSuiteTest extends Admin_FrbrLinktypeContro public function labelForFromBToAInputShouldBeFromBToA() { $this->assertXPathContentContains('//label[@for="from_target"]', 'de l\'objet B vers l\'objet A'); } - + } diff --git a/tests/application/modules/admin/controllers/LieuControllerTest.php b/tests/application/modules/admin/controllers/LieuControllerTest.php index 64d3da1b900cfc45da98faafc910ee54867b7291..6991c1767fd98bb53f8640800fd45df2c5f144b6 100644 --- a/tests/application/modules/admin/controllers/LieuControllerTest.php +++ b/tests/application/modules/admin/controllers/LieuControllerTest.php @@ -63,7 +63,7 @@ class LieuControllerListTest extends LieuControllerTestCase { /** @test */ public function linktoUpdateCoordinatesShouldBePresent() { - $this->assertXPath('//div[contains(@onclick, "/admin/lieu/update-coordinates")]'); + $this->assertXPath('//button[contains(@onclick, "/admin/lieu/update-coordinates")]'); } @@ -99,7 +99,7 @@ class LieuControllerListTest extends LieuControllerTestCase { /** @test */ public function pageShouldContainsButtonToCreateLieu() { - $this->assertXPathContentContains('//div[contains(@onclick, "lieu/add")]//td', 'Déclarer un nouveau lieu'); + $this->assertXPathContentContains('//button[contains(@onclick, "lieu/add")]', 'Créer un lieu'); } diff --git a/tests/application/modules/admin/controllers/NewsletterControllerTest.php b/tests/application/modules/admin/controllers/NewsletterControllerTest.php index 9a3a12ba1c147ab55bac4c3df089d3bc0ea073d8..74fe8a9ba4c082c6c9f86c6197ef7d24e7967fa9 100644 --- a/tests/application/modules/admin/controllers/NewsletterControllerTest.php +++ b/tests/application/modules/admin/controllers/NewsletterControllerTest.php @@ -204,7 +204,7 @@ class Admin_NewsletterControllerIndexActionTest extends Admin_NewsletterControll public function testAddLink() { - $this->assertXPath("//div[contains(@onclick, '/admin/newsletter/add')]"); + $this->assertXPath("//button[contains(@onclick, '/admin/newsletter/add')]"); } } diff --git a/tests/application/modules/admin/controllers/OpdsControllerTest.php b/tests/application/modules/admin/controllers/OpdsControllerTest.php index 91a91791a82802888a4b41a89d47eda964a1f30b..115f950335f71393457a720888b7e5161eb27f27 100644 --- a/tests/application/modules/admin/controllers/OpdsControllerTest.php +++ b/tests/application/modules/admin/controllers/OpdsControllerTest.php @@ -97,7 +97,7 @@ class Admin_OpdsControllerIndexActionTest extends Admin_OpdsControllerTestCase { /** @test */ public function shouldHaveAddCatalogButton() { - $this->assertXPath('//div[contains(@onclick, "opds/add")]'); + $this->assertXPath('//button[contains(@onclick, "opds/add")]'); } diff --git a/tests/application/modules/admin/controllers/ProfilControllerIndexTest.php b/tests/application/modules/admin/controllers/ProfilControllerIndexTest.php index 7db9b423250a4a3359fee23958e17b989b8a6043..756218ec411801bd66a43e437478f0283ae785a5 100644 --- a/tests/application/modules/admin/controllers/ProfilControllerIndexTest.php +++ b/tests/application/modules/admin/controllers/ProfilControllerIndexTest.php @@ -156,7 +156,7 @@ class Admin_ProfilControllerWithAdminPortailIndexTest extends Admin_ProfilContro /** @test */ public function buttonAjouterProfilShouldBeVisible() { - $this->assertXPathContentContains("//div[contains(@onclick, 'profil/add')]", + $this->assertXPathContentContains("//button[contains(@onclick, 'profil/add')]", "Ajouter un profil"); } diff --git a/tests/application/modules/admin/controllers/RedmineControllerTest.php b/tests/application/modules/admin/controllers/RedmineControllerTest.php index c9d7845fb8aead57657837584a5deb193cbba9ab..73044bcc5fd614f44d8774f53658fdfed67a5347 100644 --- a/tests/application/modules/admin/controllers/RedmineControllerTest.php +++ b/tests/application/modules/admin/controllers/RedmineControllerTest.php @@ -294,7 +294,7 @@ class Admin_RedmineControllerIndexTest extends Admin_RedmineControllerWithApiTes /** @test */ public function anchorToEditBibsShouldBePresent() { - $this->assertXPath('//div[@class="modules"]//a[contains(@href, "admin/bib/edit/id/1")]'); + $this->assertXPath('//div[@class="modules"]//button[contains(@onclick, "admin/bib/edit/id/1/backUrl/")]'); } @@ -375,7 +375,7 @@ class Admin_RedmineControllerIndexActionWithModoBibTest extends Admin_RedmineCon /** @test */ public function noAccountHaveBeenSetMessageShouldBePresent() { - $this->assertXPathContentContains('//div[@class="modules"]//a[contains(@href, "admin/bib/edit/id/1")]', 'Modifier le compte d\'assistance', $this->_response->getBody()); + $this->assertXPathContentContains('//div[@class="modules"]//button[contains(@onclick, "admin/bib/edit/id/1")]', 'Modifier le compte d\'assistance'); } } diff --git a/tests/application/modules/admin/controllers/UserGroupControllerTest.php b/tests/application/modules/admin/controllers/UserGroupControllerTest.php index eaa2073355b0b6e26e19d39d0327d34fe32fd9b1..7f5a9195d148421a4355535531cac1530a99c7d9 100644 --- a/tests/application/modules/admin/controllers/UserGroupControllerTest.php +++ b/tests/application/modules/admin/controllers/UserGroupControllerTest.php @@ -554,7 +554,7 @@ class Admin_UserGroupControllerEditMembersGroupAbonnesSIGBTest /** @test */ public function backButtonShouldLinkToUsergroupController() { - $this->assertXPath('//div[contains(@onclick, "/admin/usergroup")]'); + $this->assertXPath('//button[contains(@onclick, "/admin/usergroup")]'); } } @@ -576,7 +576,7 @@ class Admin_UserGroupControllerEditMembersGroupAbonnesSIGBFromNewsletterTest /** @test */ public function backButtonShouldLinkToNewsletterController() { - $this->assertXPath('//div[contains(@onclick, "/admin/newsletter/edit-subscribers/id/43")]'); + $this->assertXPath('//button[contains(@onclick, "/admin/newsletter/edit-subscribers/id/43")]'); } } diff --git a/tests/application/modules/admin/controllers/UsersControllerTest.php b/tests/application/modules/admin/controllers/UsersControllerTest.php index ebe8a4becd432c2aef16aee924ae773bb9cf4d11..87d25244d1fe14887c552b531ffb460358af2ef8 100644 --- a/tests/application/modules/admin/controllers/UsersControllerTest.php +++ b/tests/application/modules/admin/controllers/UsersControllerTest.php @@ -153,7 +153,7 @@ class UsersControllerIndexTest extends UsersControllerWithMarcusTestCase { /** @test */ public function addUserButtonShouldBePresent() { - $this->assertXPath('//div[contains(@onclick, "admin/users/add")]'); + $this->assertXPath('//button[contains(@onclick, "admin/users/add")]'); } diff --git a/tests/application/modules/opac/controllers/AbonneControllerNewslettersTest.php b/tests/application/modules/opac/controllers/AbonneControllerNewslettersTest.php index f5d2e07e877780349b0f1bcd77d08e5c74c93e39..b83784d68c7cba02c5f844cb6799f28e84c3df8a 100644 --- a/tests/application/modules/opac/controllers/AbonneControllerNewslettersTest.php +++ b/tests/application/modules/opac/controllers/AbonneControllerNewslettersTest.php @@ -268,7 +268,7 @@ class AbonneControllerNewslettersEditActionTest extends AbonneControllerWithTwoN } public function testBackButton() { - $this->assertXPath("//div//button[@class='bouton back'][@data-url='/abonne'][contains(@onclick, 'window.location =')][contains(@onclick, '/abonne')]"); + $this->assertXPath("//div//button[@class='bouton back'][@data-url='/abonne'][contains(@onclick, 'window.location.href =')][contains(@onclick, '/abonne')]"); } /** @test */ diff --git a/tests/application/modules/opac/controllers/AbonneControllerTagNoticeTest.php b/tests/application/modules/opac/controllers/AbonneControllerTagNoticeTest.php index 64822bb4c737de7b09315c524874a2d799e9d563..236d689ef2917e09983c32ed5e4f62973a25e402 100644 --- a/tests/application/modules/opac/controllers/AbonneControllerTagNoticeTest.php +++ b/tests/application/modules/opac/controllers/AbonneControllerTagNoticeTest.php @@ -47,7 +47,7 @@ class AbonneControllerTagNoticeAddTagPopupTest extends AbonneControllerTagNotice $this->dispatch('/noticeajax/add-tag/id/23', true); $json = json_decode($this->_response->getBody()); - $this->assertContains('a name="login_form"', + $this->assertContains('input type="text" name="username"', $json->content); } } diff --git a/tests/scenarios/ExternalAgendas/ExternalAgendasTest.php b/tests/scenarios/ExternalAgendas/ExternalAgendasTest.php index fc6a057b2b2eee8e212e8b69002b93598c6a24b2..f3e099e97f81b5d91dda6505f77c41ffab642e46 100644 --- a/tests/scenarios/ExternalAgendas/ExternalAgendasTest.php +++ b/tests/scenarios/ExternalAgendas/ExternalAgendasTest.php @@ -93,7 +93,7 @@ class ExternalAgendasAdminIndexTest extends ExternalAgendasAdminTestCase { /** @test */ public function pageShouldContainsButtonAddAgenda() { - $this->assertXPathContentContains('//div[contains(@onclick, "admin/external-agendas/add")]', + $this->assertXPathContentContains('//button[contains(@onclick, "admin/external-agendas/add")]', 'Ajouter un agenda'); } @@ -489,7 +489,7 @@ class ExternalAgendasAdminImportTest extends ExternalAgendasAdminTestCase { /** @test */ public function pageShouldContainsABackButton() { - $this->assertXPathContentContains('//div[contains(@onclick, "replace(\'/admin/external-agendas\')")]//td', + $this->assertXPathContentContains('//button[contains(@onclick, "/admin/external-agendas")]', 'Retour à la liste des agendas'); }