diff --git a/library/ZendAfi/View/Helper/TagRechercheSimple.php b/library/ZendAfi/View/Helper/TagRechercheSimple.php index 05e1dfd17a6ffab64bea159e02948758619eb936..f74bd84dd3b1c4f0420aa5f65ae4478cbdcf6240 100644 --- a/library/ZendAfi/View/Helper/TagRechercheSimple.php +++ b/library/ZendAfi/View/Helper/TagRechercheSimple.php @@ -56,12 +56,12 @@ class ZendAfi_View_Helper_TagRechercheSimple extends Zend_View_Helper_HtmlElemen public function renderSelectionBib() { - if ($this->preferences["select_bib"] !== 1) + if ((int)$this->preferences["select_bib"] !== 1) return ''; - return isset($_SESSION['selection_bib']['id_bibs']) - ? '<input type="hidden" name="bib_select" value="'.$_SESSION['selection_bib']['id_bibs'].'" />' - : '<div>'. $_SESSION["selection_bib"]["html"] .'</div>'; + return (isset($_SESSION['selection_bib']['id_bibs']) + ? '<input type="hidden" name="bib_select" value="'.$_SESSION['selection_bib']['id_bibs'].'" />' + : ''). '<div>'. $_SESSION["selection_bib"]["html"] .'</div>'; } diff --git a/tests/library/ZendAfi/View/Helper/TagRechercheSimpleTest.php b/tests/library/ZendAfi/View/Helper/TagRechercheSimpleTest.php index 1efce1ef479d37e8a81084251a9075d4e3a5b091..ff2972f742c0d8fade9ae3bfaf682d0aa26853a2 100644 --- a/tests/library/ZendAfi/View/Helper/TagRechercheSimpleTest.php +++ b/tests/library/ZendAfi/View/Helper/TagRechercheSimpleTest.php @@ -19,6 +19,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +require_once('ViewHelperTestCase.php'); + class ZendAfi_View_Helper_TagRechercheSimpleTest extends ViewHelperTestCase { /** @var ZendAfi_View_Helper_TagRechercheSimple */ protected $_helper; @@ -71,6 +73,19 @@ class ZendAfi_View_Helper_TagRechercheSimpleTest extends ViewHelperTestCase { $html = $this->_helper->tagRechercheSimple($this->_preferences, 1); $this->assertXPath($html, '//form//input[@name="expressionRecherche"][@placeholder="ex: Nineteen Eighty Four"]'); } + + + /** @test */ + public function withSelectionBibShouldRenderSessionValue() { + $this->_preferences['select_bib'] = '1'; + $_SESSION['selection_bib'] = ['html' => 'recherche dans des bibs', + 'id_bibs' => '3,4,5']; + + $html = $this->_helper->tagRechercheSimple($this->_preferences, 1); + + $this->assertXPath($html, '//form//input[@name="bib_select"][@type="hidden"][@value="3,4,5"]'); + $this->assertXPathContentContains($html, '//div', 'recherche dans des bibs'); + } } ?> \ No newline at end of file