Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Open sidebar
bibliossimo
opacce
Commits
410b602c
Commit
410b602c
authored
Feb 19, 2018
by
Ghislain Loas
Browse files
Merge branch 'dev#71664_prettyphoto_ko' into 'master'
Dev#71664 prettyphoto ko See merge request
afi/opacce!2507
parents
5f2e1717
2d1ab41d
Changes
86
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
8 additions
and
37 deletions
+8
-37
tests/application/modules/admin/controllers/CmsControllerTest.php
...plication/modules/admin/controllers/CmsControllerTest.php
+4
-10
tests/application/modules/admin/controllers/ProfilControllerIndexTest.php
...n/modules/admin/controllers/ProfilControllerIndexTest.php
+1
-7
tests/application/modules/admin/controllers/SitothequeControllerTest.php
...on/modules/admin/controllers/SitothequeControllerTest.php
+0
-1
tests/application/modules/opac/controllers/BibNumeriqueControllerTest.php
...n/modules/opac/controllers/BibNumeriqueControllerTest.php
+0
-6
tests/application/modules/opac/controllers/PanierControllerTest.php
...ication/modules/opac/controllers/PanierControllerTest.php
+1
-1
tests/library/ZendAfi/View/Helper/Accueil/BibNumeriqueTest.php
.../library/ZendAfi/View/Helper/Accueil/BibNumeriqueTest.php
+2
-12
No files found.
tests/application/modules/admin/controllers/CmsControllerTest.php
View file @
410b602c
...
...
@@ -771,13 +771,13 @@ class CmsControllerArticleConcertEditActionTest extends CmsControllerWithPermiss
/** @test */
function
previewShouldContainsArticleUrl
()
{
$this
->
assertXPath
(
'//a[
@data-prettyphoto="true"][
contains(@href, "/cms/articleview/id/4")]'
);
$this
->
assertXPath
(
'//a[contains(@href, "/cms/articleview/id/4")]'
);
}
/** @test */
function
previewTitleShouldBeVisualisationDeLArticle
()
{
$this
->
assertXPath
(
'//a[
@data-prettyphoto="true"][contains(@title, "Visualisation de l\'article:
Erik Truffaz en concert")]'
);
$this
->
assertXPath
(
'//a[
contains(@title, "
Erik Truffaz en concert")]'
);
}
...
...
@@ -811,13 +811,7 @@ class CmsControllerArticleConcertEditRenderPopupActionTest extends CmsController
/** @test */
public
function
tagPreviewArticleShouldNotHaveRenderPopupInLink
()
{
$this
->
_xpath
->
assertXPath
(
$this
->
_json
->
content
,
'//a[contains(@href, "cms/articleview/id/4?iframe=true")]'
);
}
/** @test */
public
function
prettyPhotoShouldBeLoaded
()
{
$this
->
_xpath
->
assertXPath
(
$this
->
_json
->
content
,
'//script[contains(@src, "jquery.prettyPhoto")]'
);
'//a[contains(@href, "cms/articleview/id/4")]'
);
}
...
...
@@ -2607,7 +2601,7 @@ class CmsControllerArticleExistingTraductionEditTest extends CmsControllerWithPe
/** @test */
function
previewShouldContainsArticleUrl
()
{
$this
->
assertXPath
(
'//a[
@data-prettyphoto="true"][
contains(@href, "cms/articleview/id/41")]'
);
$this
->
assertXPath
(
'//a[contains(@href, "cms/articleview/id/41")]'
);
}
}
...
...
tests/application/modules/admin/controllers/ProfilControllerIndexTest.php
View file @
410b602c
...
...
@@ -124,13 +124,7 @@ class Admin_ProfilControllerWithAdminPortailIndexTest extends Admin_ProfilContro
/** @test */
function
previewPageAccueilAnchorTitleShouldBeVisualisationDeLaPageAdulte
()
{
$this
->
assertXPath
(
'//div/ul[1]//li[1]//a[@data-prettyphoto="true"][contains(@title, "Visualisation de la page \'Adulte\'")][@href="/index/index/id_profil/8?iframe=true&width=95%25&height=95%25"]'
);
}
/** @test */
public
function
prettyPhotoShouldBeLoaded
()
{
$this
->
assertXPath
(
'//script[contains(@src, "public/admin/js/prettyphoto/js/jquery.prettyPhoto.js")]'
);
$this
->
assertXPath
(
"//div/ul[1]//li[1]//a[contains(@title, 'Ouvrir la page
\"
Adulte
\"
')][@href='/index/index/id_profil/8']"
);
}
...
...
tests/application/modules/admin/controllers/SitothequeControllerTest.php
View file @
410b602c
...
...
@@ -167,7 +167,6 @@ class SitothequeControllerSitoEditTest extends SitothequeControllerTestCase {
/**
* @group integration
* @disabledtest (anchor with attribute rel = prettyPhoto is not html5 valid)
*/
public
function
pageShouldBeHtml5Valid
()
{
$this
->
assertHTML5
();
...
...
tests/application/modules/opac/controllers/BibNumeriqueControllerTest.php
View file @
410b602c
...
...
@@ -421,12 +421,6 @@ class BibNumeriqueControllerViewAlbumActionPremierVolumeTest extends AbstractBib
}
/** @test */
public
function
viewerScriptShouldBePresent
()
{
$this
->
assertXPath
(
'//script[contains(@src, "prettyPhoto.js")]'
);
}
/** @test */
public
function
pageBibNumShouldBeHTML5Compliant
()
{
$this
->
assertHTML5
();
...
...
tests/application/modules/opac/controllers/PanierControllerTest.php
View file @
410b602c
...
...
@@ -358,7 +358,7 @@ class PanierControllerIndexWithPanierIdFifteenTest extends PanierControllerTestC
/** @test */
public
function
pageShouldContainsLinkToViewNoticeMontespan
()
{
$this
->
assertXPath
(
'//a[contains(@href, "/recherche/viewnotice/id/4
?iframe=true
")]'
);
$this
->
assertXPath
(
'//a[contains(@href, "/recherche/viewnotice/id/4")]'
);
}
}
...
...
tests/library/ZendAfi/View/Helper/Accueil/BibNumeriqueTest.php
View file @
410b602c
...
...
@@ -420,23 +420,13 @@ class BibNumeriqueAlbumTeaserTest extends AbstractBibNumeriqueViewHelperWithAlbu
* @depends withoutOrderInPrefShouldRespectInitialOrder
* @test
*/
public
function
secondImageShouldLinkToFullImage
PrettyPhoto
(
$html
)
{
public
function
secondImageShouldLinkToFullImage
(
$html
)
{
$this
->
assertXPath
(
$html
,
'//a[contains(@href, "/bib-numerique/get-resource/id/2")][
@data-rel="prettyphoto[Harlock]"][
@title
=
"Le capitaine en slip"]'
,
'//a[contains(@href, "/bib-numerique/get-resource/id/2")][
contains(
@title
,
"Le capitaine en slip"
)
]'
,
$html
);
}
/** @test */
public
function
pageShouldContainsCodeToLoadPrettyPhoto
()
{
$this
->
_buildHelperLimitedTo
(
2
);
$this
->
_helper
->
getBoite
();
$this
->
assertXPath
(
Class_ScriptLoader
::
getInstance
()
->
html
(),
'//script[contains(@src,"prettyPhoto")]'
);
}
/** @test */
public
function
withOrderRespectInPrefShouldRespectInitialOrder
()
{
$this
->
_buildHelperLimitedToFourOrderedBy
(
Class_Systeme_ModulesAccueil_BibliothequeNumerique
::
ORDER_SELECTION
);
...
...
Prev
1
2
3
4
5
Next
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment