Merge branch 'hotline#75970_preinscription_probleme_avec_de_fausses_preinscriptions' into 'hotline'

hotline #75070 : add captcha in Nanook pre-registration

See merge request !2691

VERSIONS_HOTLINE/75970

+ - ticket #75970 : Abonné : Pré-inscription Nanook : ajout de contre-mesures antispam
\ No newline at end of file

library/ZendAfi/Form/PreRegistration/Nanook.php

@@ -25,7 +25,6 @@ class ZendAfi_Form_PreRegistration_Nanook extends ZendAfi_Form {
     parent::init();
 
     $this
-
       ->addElement('select',
                    'site',
                    ['label' => $this->_('Médiathèque'),
@@ -56,6 +55,10 @@ class ZendAfi_Form_PreRegistration_Nanook extends ZendAfi_Form {
                     'allowEmpty' => false,
                     'validators' => [new ZendAfi_Validate_MailEquals('mail')]])
 
+      ->addElement('text',
+                   'emailCheck',
+                   ['data-spambots' => 'true'])
+
       ->addElement('password',
                    'password',
                    ['label' => $this->_('Mot de passe'),

tests/application/modules/opac/controllers/AuthControllerPreRegistrationTest.php

@@ -319,6 +319,12 @@ class AuthControllerPreRegistrationNanookDispatchTest
   public function selectSiteShouldContainsOptionAcardia() {
     $this->assertXPathContentContains('//form//select[@name="site"]//option[@value="1"]', 'Arcadia');
   }
+
+
+  /** @test */
+  public function formShouldContainsCaptcha() {
+    $this->assertXPath('//input[@name="emailCheck"]');
+  }
 }
 
 
@@ -353,7 +359,8 @@ class AuthControllerPreRegistrationNanookPostDispatchTest
                                                         'birthDate' => '2001-05-05',
                                                         'town' => 'titi',
                                                         'zipcode' => '123456',
-                                                        'address' => '123']);
+                                                        'address' => '123',
+                                                        'emailCheck' => '']);
   }
 
 
@@ -419,7 +426,8 @@ class AuthControllerPreRegistrationNanookPostDispatchErrorTest
                                                         'birthDate' => '2001-05-05',
                                                         'town' => 'titi',
                                                         'zipcode' => '123456',
-                                                        'address' => '123']);
+                                                        'address' => '123',
+                                                        'emailCheck' => '']);
   }
 
 
@@ -431,6 +439,35 @@ class AuthControllerPreRegistrationNanookPostDispatchErrorTest
 
 
 
+class AuthControllerPreRegistrationNanookPostDispatchSpamTest
+  extends AuthControllerPreRegistrationNanookTestCase {
+
+  public function setUp() {
+    parent::setUp();
+
+    $this->postDispatch('/opac/auth/pre-registration', ['site' => '1',
+                                                        'lastName' => 'Jiro',
+                                                        'firstName' => 'Tom',
+                                                        'mail' => 'test@test.fr',
+                                                        'mail2' => 'test@test.fr',
+                                                        'password' => 'pwd123456',
+                                                        'password2' => 'pwd123456',
+                                                        'birthDate' => '2001-05-05',
+                                                        'town' => 'titi',
+                                                        'zipcode' => '123456',
+                                                        'address' => '123',
+                                                        'emailCheck' => 'russian-pal@poutine.ru']);
+  }
+
+
+  /** @test */
+  public function shouldRedirectToHome() {
+    $this->assertRedirectTo('/');
+  }
+}
+
+
+
 
 class AuthControllerPreRegistrationWithNoPreRegistrationTest extends AuthControllerPreRegistrationNanookTestCase {
   public function setUp() {