Merge branch...

Merge branch 'hotline#121248_cacher_le_bouton_mes_comptes_associes_dans_le_compte_lecteur_quand_aucun_fournisseur_d_identite_n_est_affiche' into 'hotline'

hotline#121248 : Associated Identities should be displayed only when Identity Providers are enabled

See merge request !3719

VERSIONS_HOTLINE/121248

+ - ticket #121248 : Fiche Abonné : Le bouton mes comptes associés dans le compte lecteur ne s\'affiche que si IdentityProviders est Activé.
\ No newline at end of file

library/ZendAfi/View/Helper/Abonne/AssociatedProviders.php

@@ -22,9 +22,12 @@
 
 class ZendAfi_View_Helper_Abonne_AssociatedProviders extends ZendAfi_View_Helper_Abonne_Abstract {
   public function abonne_associatedProviders($user) {
-    return $this->tagFicheAbonne($this->_('Mes comptes associés'),
-                                 'cards',
-                                 $this->view->url(['controller' => 'abonne',
-                                                   'action' => 'associated-providers']));
+    return (Class_AdminVar::isIdentityProvidersEnabled()
+            && (Class_IdentityProvider::countBy(['active'=>true]) > 0))
+      ? $this->tagFicheAbonne($this->_('Mes comptes associés'),
+                              'cards',
+                              $this->view->url(['controller' => 'abonne',
+                                                'action' => 'associated-providers']))
+      :'';
   }
 }

tests/application/modules/opac/controllers/AbonneControllerFicheTest.php

@@ -191,6 +191,29 @@ class AbonneControllerFicheAsAdminDisableSuggestAndBookmarkableLibrariesTest ext
 
 
 
+
+class AbonneControllerFicheWithIdentityProvidersEnabledTest extends AbstractAbonneControllerFicheTest {
+
+  public function setUp() {
+    parent::setUp();
+    Class_AdminVar::set('ENABLE_IDENTITY_PROVIDERS', 1);
+    Class_IdentityProvider::newInstance(['label' => 'cassifié',
+                                         'type' => 'cas2',
+                                         'config' => '{"client_id":"ABCD";"client_secret":"EFGH"}',
+                                         'active' => true])->assertSave();
+    $this->dispatch('/abonne/fiche', true);
+  }
+
+
+  /** @test */
+  public function linkToAssociatedProvidersShouldBePresent() {
+    $this->assertXPath('//a[contains(@href, "/abonne/associated-providers")]');
+  }
+}
+
+
+
+
 class AbonneControllerFicheActionWithLoggedUserTest extends AbstractAbonneControllerFicheTest {
   public function setUp() {
     parent::setUp();
@@ -210,9 +233,11 @@ class AbonneControllerFicheActionWithLoggedUserTest extends AbstractAbonneContro
   }
 
 
-  /** @test */
-  public function mesComptesAssociesLinkShouldBePresent() {
-    $this->assertXPath('//div//a[contains(@href, "/abonne/associated-providers")]');
+  /** @test
+   *  cf https://forge.afi-sa.net/issues/121248
+   */
+  public function withIdentityProvidersDisabledmesComptesAssociesLinkShouldNotBePresent() {
+    $this->assertNotXPath('//div//a[contains(@href, "/abonne/associated-providers")]');
   }
 
 }