dev #12521 : update type list if id exists

library/Class/CosmoVar.php

@@ -42,13 +42,29 @@ class Class_CosmoVarLoader extends Storm_Model_Loader {
 		return '';
 	}
 
+	public function updateLabelInList($value ,$label ,$list) {
+		$new_list=[];
+		foreach (explode(chr(13).chr(10), $list) as $line) {
+			$parts = explode(':', $line);
+			if ($value == $parts[0])
+				$parts[1]=$label;
+			$new_list[]=implode(':', $parts);
+		}
+		return implode('\r\n',$new_list);
+	}
+
 
 	public function addLabelInList($name, $value, $label) {
 			if (!$model = Class_CosmoVar::find($name))
 				return false;
 
 			$liste = $model->getListe();
-			$liste .= "\r\n$value:$label";
+
+			if (strpos($liste, "\r\n$value:") !== false)
+				$liste=$this->updateLabelInList($value,$label,$liste);
+			else 
+				$liste .= "\r\n$value:$label";
+
 			$model->setListe($liste)->save();
 
 			return $this;

tests/library/Class/TypeDocTest.php

@@ -137,6 +137,24 @@ class TypeDocTest extends Storm_Test_ModelTestCase {
 		Class_CosmoVar::AddLabelInList('types_docs', 111, 'Cyberlibris');
 		$this->assertContains('111:Cyberlibris', $this->cosmo_types->getListe());
 	}
+
+
+	/** @test */
+	public function couldnotAddLabelIfAlreadyExists() {
+		Class_CosmoVar::AddLabelInList('types_docs', 111, 'Cyberlibris');
+		Class_CosmoVar::AddLabelInList('types_docs', 111, 'Cyberlibris');
+		$this->assertEquals('0:non identifié\r\n1:livres\r\n2:périodiques\r\n111:Cyberlibris', $this->cosmo_types->getListe());
+	}
+
+
+	/** @test */
+	public function ifLabelExistsShouldUpdateLabel() {
+		Class_CosmoVar::AddLabelInList('types_docs', 111, 'Cyberlibris');
+		Class_CosmoVar::AddLabelInList('types_docs', 111, 'Other');
+		$this->assertContains('111:Other', $this->cosmo_types->getListe());
+	}
+
+
 }
 
 ?>
\ No newline at end of file