rel #32417 : fix filemanager authorization to accept filenames containing two dots

VERSIONS_HOTLINE/32417

+ - ticket #32417 : Explorateur de fichiers : Corrige une erreur d'autorisation pour les fichiers dont le nom contient ".."
\ No newline at end of file

library/Class/FileManager.php

@@ -21,9 +21,12 @@
 
 class Class_FileManager {
   public function isAuthorized($path) {
-    return Class_Users::isCurrentUserCanAccesBackend()
-      && false !== strpos($path, USERFILESURL)
-      && false === strpos($path, '..');
+    if (!Class_Users::isCurrentUserCanAccesBackend()
+        || false === strpos($path, USERFILESURL))
+      return false;
+
+    $parts = explode('/', $path);
+    return !in_array('..', $parts);
   }
 }
 

tests/library/Class/FileManagerTest.php

@@ -91,6 +91,15 @@ class FileManagerAsAdminTest extends ModelTestCase {
   public function upperDirectoryShouldNotBeAuthorized() {
     $this->assertFalse($this->_filemanager->isAuthorized(USERFILESURL . '../'));
   }
+
+
+  /**
+   * @test
+   * @see http://forge.afi-sa.fr/issues/32417
+   */
+  public function filenameContainingTwoDotsShouldBeAuthorized() {
+    $this->assertTrue($this->_filemanager->isAuthorized(USERFILESURL . '/Spectacle_14_nov..pdf'));
+  }
 }
 
 ?>
\ No newline at end of file