fix isCommKoha() in Class_IntBib

library/Class/IntBib.php

@@ -569,7 +569,7 @@ class Class_IntBib extends Storm_Model_Abstract {
 
 
   public function isCommKoha() {
-    return $this->getCommSigb() == (static::COM_KOHA || static::COM_KOHA_LEGACY);
+    return in_array($this->getCommSigb(), [static::COM_KOHA, static::COM_KOHA_LEGACY]);
   }
 
 

tests/library/Class/IntBibTest.php

@@ -99,8 +99,43 @@ class IntBibSingleNanookTest extends ModelTestCase {
   }
 
 
+  /** @test */
+  public function shouldNotBeCommKoha() {
+    $this->assertFalse(Class_IntBib::find(78)->isCommKoha());
+  }
+
+
   /** @test */
   public function shouldBeSingleNanookPatrons() {
     $this->assertTrue(Class_IntBib::isSingleNanookPatrons());
   }
-}
\ No newline at end of file
+}
+
+
+
+
+class IntBibKohaTest extends ModelTestCase {
+  public function setUp() {
+    parent::setUp();
+
+    $this->fixture(Class_IntBib::class,
+                   ['id' => 78,
+                    'sigb' => Class_IntBib::SIGB_KOHA,
+                    'comm_sigb' => Class_IntBib::COM_KOHA,
+                    'comm_params' => 'a:1:{s:11:"url_serveur";s:53:"http://nanookws.afi-sa.net/afi_NanookWs/ilsdi/meylan/";}']);
+  }
+
+
+  /** @test */
+  public function shouldBeCommKoha() {
+    $this->assertTrue(Class_IntBib::find(78)->isCommKoha());
+  }
+
+
+  /** @test */
+  public function shouldBeCommKohaAlsoWithLegacy() {
+    $int_bib = Class_IntBib::find(78);
+    $int_bib->setCommSigb(Class_IntBib::COM_KOHA_LEGACY);
+    $this->assertTrue($int_bib->isCommKoha());
+  }
+}