hotline : #186186 : with var at 0 created uers datefin with

currenttime - 1

VERSIONS_HOTLINE/186186

+ - correctif #186186 : Abonnés portail : Un abonnement ne sera plus valide avec une PORTAL_BORROWERS_VALIDATION_DELAY = 0.
\ No newline at end of file

library/Class/User/ILSSubscription.php

@@ -193,7 +193,12 @@ class Class_User_ILSSubscription {
     $this->_user->beAbonnePortail();
 
     $date = new DateTime($this->getTimeSource()->dateYmd());
-    $date->modify('+' . $days . ' day');
+
+    if ($days > 0)
+      $date->modify('+' . $days . ' day');
+
+    if ($days <= 0)
+      $date->modify('-1 day');
 
     $this->_user->setDateFin($date->format('Y-m-d'));
     return $this;

tests/scenarios/PortalBorrowers/PortalBorrowersFrontTest.php

@@ -242,6 +242,45 @@ class PortalBorrowersFrontRegisterActivationTest extends PortalBorrowersActivate
 
 
 
+/* hotline : https://forge.afi-sa.net/issues/186186 */
+class PortalBorrowersFrontRegisterActivationWithValidationDelayZeroTest
+  extends PortalBorrowersActivatedTestCase {
+
+  public function setUp() {
+    parent::setUp();
+
+    Class_AdminVar::set('PORTAL_BORROWERS_LIBRARIES_IDS', '1');
+    Class_AdminVar::set('PORTAL_BORROWERS_VALIDATION_DELAY', '0');
+
+    $time_source = (new TimeSourceForTest('2022-10-21 10:43:04'));
+    Class_User_ILSSubscription::setTimeSource($time_source);
+
+    $activation_key = 'zzhz';
+    $this->fixture(Class_UsersNonValid::class,
+                   ['id' => 188,
+                    'login' => 'newuser',
+                    'password' => 'pass',
+                    'mail' => 'user@server.io',
+                    'date' => $time_source->time(),
+                    'id_site' => '1',
+                    'civilite' => '1',
+                    'naissance' => '1977-08-18',
+                    'cle' => $activation_key]);
+
+    $this->dispatch('/opac/auth/activeuser?c=' . $activation_key);
+  }
+
+
+  /** @test */
+  public function createdUserDateFinShouldBeCurrentDayLessOne() {
+    $this->assertEquals('2022-10-20',
+                        Class_Users::findFirstBy(['login' => 'newuser'])->getDateFin());
+  }
+}
+
+
+
+
 class PortalBorrowersFrontDisabledRegisterTest extends PortalBorrowersDisabledTestCase {
   public function setUp() {
     parent::setUp();