Merge branch 'hotline#138642_mise_a_jour_du_webservice_koha' into 'hotline'

hotline#138642 : fix webservice parameter names for calendar holds with Koha

See merge request !4156

VERSIONS_HOTLINE/138642

+ - ticket #138642 : SIGB Koha : Mise à jour des paramêtres requis pour une réservation calendaire.
\ No newline at end of file

library/Class/WebService/SIGB/Koha/Service.php

@@ -292,8 +292,8 @@ class Class_WebService_SIGB_Koha_Service extends Class_WebService_SIGB_AbstractR
                                 $this->_setPickupLocation(['patron_id' => $this->_getUserPatronId($user),
                                                            'bib_id' => $exemplaire->getBibNumberFromIdOrigine(),
                                                            'item_id' => $exemplaire->getSubfield(9),
-                                                           'needed_before_date' => $reservedate,
-                                                           'pickup_expiry_date' => $expirationdate],
+                                                           'start_date' => $reservedate,
+                                                           'expiry_date' => $expirationdate],
                                                           $code_annexe),
                                  'code');
 

tests/library/Class/WebService/SIGB/KohaTest.php

@@ -1127,7 +1127,7 @@ class KohaGetRecordElementaireMonCherPolarTest extends KohaTestCase {
 
     $this->mock_web_client
       ->whenCalled('open_url')
-        ->with('http://cat-aficg55.biblibre.com/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=007&bib_id=1&item_id=123&needed_before_date=2020-01-19&pickup_expiry_date=2020-02-25&pickup_location=007')
+        ->with('http://cat-aficg55.biblibre.com/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=007&bib_id=1&item_id=123&start_date=2020-01-19&expiry_date=2020-02-25&pickup_location=007')
         ->answers("<HoldTitle>
                       <title>Elementaire mon cher Polar</title>
                       <pickup_location>007</pickup_location>