minsoc_hotline_109030 fix error on amend commit

library/ZendAfi/Form/Decorator/AuthorityPicker.php

@@ -42,8 +42,7 @@ pick_url:' . json_encode($view->url($this->_getParams(), null, true)) .'
       . $view->tag('div',
                    $view->formHidden($input_id, $this->_element->getValue())
 
-                   . $view->tag('span', $this->_element->getRecordLabel(), ['id' => 'authority_subject_selected_value_'.$this->_element->getId()])
-
+                   . $view->tag('span', $this->_element->getRecordLabel(), ['id' => 'authority_subject_selected_value_'.$input_id])
                    . $view->button_New((new Class_Entity)
                                        ->setText($this->_element->getPickButtonLabel())
                                        ->setAttribs(['onclick' => 'return false;']))

library/ZendAfi/View/Helper/AuthoritySearch/Record.php

@@ -47,6 +47,7 @@ class ZendAfi_View_Helper_AuthoritySearch_Record extends ZendAfi_View_Helper_Bas
                  ->setAttribs(['onclick' => 'return false;',
                                'data-record' => $record->getId(),
                                'data-label' => $label,
+                               'id' => 'button_select_authority_'.$select_for,
                                'class' => 'authority_pick']));
     }
 

public/opac/js/authority_picker/authority_picker.js

@@ -29,7 +29,8 @@
     var selected_value = this.find('#authority_subject_selected_value_'+options.name);
 
     opacDialogRegisterOnOpen(function() {
-      $('#opac-dialog button.authority_pick').click(on_pick);
+      if ($('#button_select_'+options.name))
+	$('#button_select_'+options.name).click(on_pick);
     });
 
     pick_button.click(function(e) {