rel #32494 : classic sitotheque menu item kept even if sito in album is activated

library/ZendAfi/View/Helper/Admin/MenuGaucheAdmin.php

@@ -74,8 +74,7 @@ class ZendAfi_View_Helper_Admin_MenuGaucheAdmin extends ZendAfi_View_Helper_Base
                       $this->filterAdmin($this->user))
 
       .$this->addMenu("sitotheque_16.png",      $this->translate()->_("Sitothèque"),             "/admin/sito",
-                      !Class_AdminVar::isSitoInAlbums()
-                      && ($this->filterAdmin($this->user) || $this->user->hasRightToAccess(Class_UserGroup::RIGHT_USER_SITOTHEQUE)))
+                      $this->filterAdmin($this->user) || $this->user->hasRightToAccess(Class_UserGroup::RIGHT_USER_SITOTHEQUE))
 
       .$this->addMenu("moderation_16.png",      $this->translate()->_("Modération"),             "/admin/modo/",
                       $this->filterAll($this->user),

tests/application/modules/admin/controllers/IndexControllerTest.php

@@ -124,9 +124,9 @@ class IndexControllerIndexSitothequeInAlbumsTest extends IndexControllerIndexSit
   }
 
   /** @test */
-  public function withSitoInAlbumsShouldNotDisplaySitothequeItemInContentManagerMenu() {
-    $this->assertNotXPathContentContains($this->_cms_menu_path . '//a', 'Sitothèque',
-                                         $this->_response->getBody());
+  public function withSitoInAlbumsShouldAlsoDisplaySitothequeItemInContentManagerMenu() {
+    $this->assertXPathContentContains($this->_cms_menu_path . '//a', 'Sitothèque',
+                                      $this->_response->getBody());
   }