Dev #32497 - Followup

application/modules/admin/controllers/NewsletterController.php

@@ -108,11 +108,12 @@ class Admin_NewsletterController extends ZendAfi_Controller_Action {
   public function duplicateAction() {
     $this->_redirect('admin/newsletter');
     if (!$newsletter = Class_Newsletter::find($this->_request->getParam('id'))) {
-      $this->_helper->notify($this->_('Duplication impossible: la source n\'a pas été trouvée'));
+      $this->_helper->notify($this->_('Duplication impossible: la source n\'a pas été trouvée.'));
       return;
     }
 
-    $newsletter->duplicate();
+    if(!$newsletter->duplicate())
+      $this->_helper->notify($this->_('Duplication impossible: Erreur lors de l\'enregisrement de la copie.'));
   }
 
 

library/Class/Newsletter.php

@@ -311,15 +311,17 @@ class Class_Newsletter extends Storm_Model_Abstract {
     $duplicate = new Class_Newsletter();
     $duplicate->updateAttributes($attributes);
 
-    if ($duplicate->save())
+    if (!$duplicate->save())
+      return false;
 
     $subscriptions = Class_NewsletterSubscription::findAllBy(['newsletter_id' => (int) $this->getId()]);
 
     foreach ($subscriptions as $subscription)
       Class_NewsletterSubscription::newWith($duplicate,
                                             $subscription->getUser());
-  }
 
+    return true;
+  }
 }
 
 ?>
\ No newline at end of file