Merge branch...

Merge branch 'hotline#137828_supprimer_une_colonne_personnalisee_du_tableau_des_exemplaires_dans_la_conf_ne_supprime_pas_la_colonne' into 'hotline'

hotline #137828 : fix phantom item custom data column

See merge request !4123

VERSIONS_HOTLINE/137828

+ - ticket #137828 : Notice : Suppression d'une colonne personnalisée vide restante après remise à 0 des colonnes personnalisées dans la configuration du tableau des exemplaires
\ No newline at end of file

library/ZendAfi/View/Helper/Notice/Exemplaires.php

@@ -180,7 +180,10 @@ class ZendAfi_View_Helper_Notice_Exemplaires extends ZendAfi_View_Helper_BaseHel
     }
 
     $subfields = Class_Profil_ItemsSettings::current()->getIncludedSubfields();
-    foreach($subfields['datas_items_code'] as  $key => $code) {
+    foreach($subfields['datas_items_code'] as $key => $code) {
+      if ('' === $code)
+        continue;
+
       $renderer = (new ZendAfi_View_Helper_Notice_ExemplairesTable_CustomColumn())
         ->setView($this->view)
         ->setExemplaires($exemplaires)

tests/application/modules/opac/controllers/NoticeAjaxControllerItemsTest.php

@@ -218,6 +218,29 @@ class NoticeAjaxControllerItemsWithoutOrderTest
 
 
 
+/** @see https://forge.afi-sa.net/issues/137828 */
+class NoticeAjaxControllerItemsWithEmptyDatasConfig extends NoticeAjaxControllerItemsTestCase {
+
+  protected function _prepareFixtures() {
+    $config = Class_Profil::getCurrentProfil()->getCfgNoticeAsArray();
+
+    $config['exemplaires']['grouper'] = '1';
+    $config['exemplaires']['datas_items_code'] = [''];
+    $config['exemplaires']['datas_items_label'] = [''];
+
+    Class_Profil::getCurrentProfil()->setCfgNotice($config);
+  }
+
+
+  /** @test */
+  public function itemsTableShouldNotContainsEmptySubfield() {
+    $this->assertNotXPath('//td[@class="subfield_"]');
+  }
+}
+
+
+
+
 class NoticeAjaxControllerItemsWithOrder995Dollar9AscTest
   extends NoticeAjaxControllerItemsTestCase {