dev #40971 : fix failures

application/modules/opac/controllers/AuthController.php

@@ -676,7 +676,7 @@ abstract class Auth_Strategy_Abstract {
   }
 
 
-  protected function _doOnLoginSuccess($user) {
+  protected function _doOnLoginSuccess() {
     if (($user = Class_Users::getIdentity()) && isset($this->on_login_success_callback))
       call_user_func($this->on_login_success_callback, $user);
     return $this;

tests/application/modules/opac/controllers/AuthControllerWithNanookTest.php

@@ -68,13 +68,12 @@ abstract class AuthControllerNanookTestCase extends AbstractControllerTestCase {
     Class_WebService_SIGB_Nanook::reset();
     parent::tearDown();
   }
-
 }
 
 
 
 
-class AuthControllerNanookPostLoginWithMailAndUnsecurePassword
+class AuthControllerWithNanookPostLoginWithMailAndUnsecurePassword
   extends AuthControllerNanookTestCase {
 
   public function setUp() {
@@ -141,7 +140,9 @@ class AuthControllerNanookPostLoginWithMailAndUnsecurePassword
 
 
 
-class AuthControllerNanookPostSecurePasswordWithMailAndUnsecurePassword extends AuthControllerNanookTestCase {
+class AuthControllerWithNanookPostSecurePasswordWithMailAndUnsecurePassword
+  extends AuthControllerNanookTestCase {
+
   public function setUp() {
     parent::setUp();
 
@@ -202,7 +203,8 @@ class AuthControllerNanookPostSecurePasswordWithMailAndUnsecurePassword extends
 
 
 
-class AuthControllerNanookPostDoSecurePasswordWithWrongCard extends AuthControllerNanookTestCase {
+class AuthControllerWithNanookPostDoSecurePasswordWithWrongCard
+  extends AuthControllerNanookTestCase {
   public function setUp() {
     parent::setUp();
 
@@ -250,12 +252,13 @@ class AuthControllerNanookPostDoSecurePasswordWithWrongCard extends AuthControll
   public function confirmPasswordShouldContainsRoxor() {
     $this->assertXPath('//form//input[@type="password"][@name="confirm_password"][@value="rox@r#1"]');
   }
-
 }
 
 
 
-class AuthControllerNanookPostDoSecurePasswordWithErrorsTest extends AuthControllerNanookTestCase {
+class AuthControllerWithNanookPostDoSecurePasswordWithErrorsTest
+  extends AuthControllerNanookTestCase {
+
   /** @test */
   public function formShouldDisplayErrorPasswordDoesNotMatch() {
     $this->postDispatch('/opac/auth/do-secure-password', ['card' => 'ZBTIC1234',
@@ -269,7 +272,6 @@ class AuthControllerNanookPostDoSecurePasswordWithErrorsTest extends AuthControl
   }
 
 
-
   /** @test */
   public function formShouldDisplayErrorPasswordDoesNotFollowPattern() {
     $this->postDispatch('/opac/auth/do-secure-password', ['card' => 'ZBTIC1234',
@@ -286,13 +288,14 @@ class AuthControllerNanookPostDoSecurePasswordWithErrorsTest extends AuthControl
 
 
 
-class AuthControllerNanookPostLoginWithMailAndUnsecurePasswordOthersLogins  extends AuthControllerNanookTestCase {
+class AuthControllerWithNanookPostLoginWithMailAndUnsecurePasswordOthersLogins
+  extends AuthControllerNanookTestCase {
+
   /** @test */
   public function withActionLoginShouldForwardToSecurePassword() {
     $this->postDispatch('/opac/auth/login', ['username' => 'name@server.tld',
                                              'password' => '1987']);
 
-
     $this->assertXPathContentContains('//p', 'Vous vous connectez', $this->_response->getBody());
   }
 
@@ -302,7 +305,6 @@ class AuthControllerNanookPostLoginWithMailAndUnsecurePasswordOthersLogins  exte
     $this->postDispatch('/opac/auth/ajax-login', ['username' => 'name@server.tld',
                                                   'password' => '1987']);
 
-
     $this->assertXPathContentContains('//p', 'Vous vous connectez', $this->_response->getBody());
   }
 }
\ No newline at end of file