rel #44519 : hide news pref in bib view applied again

library/ZendAfi/View/Helper/NewsBibHelper.php

@@ -24,6 +24,9 @@ class ZendAfi_View_Helper_NewsBibHelper extends ZendAfi_View_Helper_BaseHelper {
   use Trait_TimeSource;
 
   public function newsBibHelper($id_bib) {
+    if ($this->_isHidden())
+      return '';
+
     $prefs = ['id_bib' => $id_bib,
               'events_only' => true,
               'display_order' => 'EventDebut',
@@ -45,6 +48,12 @@ class ZendAfi_View_Helper_NewsBibHelper extends ZendAfi_View_Helper_BaseHelper {
   }
 
 
+  protected function _isHidden() {
+    return 1 == Class_Profil::getCurrentProfil()
+      ->getModulePreference('bib', 'bibview', 'hide_news');
+  }
+
+
   protected function _renderArticles($articles) {
     $helper = $this->view->getHelper('Article_RenderWall');
     return $this->view->tag('div', implode('',

tests/application/modules/opac/controllers/BibControllerTest.php

@@ -83,6 +83,11 @@ abstract class BibControllerWithZoneTestCase extends AbstractControllerTestCase
                  'event_end_after' => '2016-07-14'])
          ->answers([$ecrivez_des_tests])
 
+         ->whenCalled('getArticlesByPreferences')
+         ->with(['id_bib' => '4'])
+         ->answers([$ecrivez_des_tests])
+
+
          ->whenCalled('getArticlesByPreferences')
          ->with(['id_bib' => '22',
                  'events_only' => true,
@@ -90,6 +95,11 @@ abstract class BibControllerWithZoneTestCase extends AbstractControllerTestCase
                  'event_end_after' => '2016-07-14'])
          ->answers([$ecrivez_des_tests])
 
+         ->whenCalled('getArticlesByPreferences')
+         ->with(['id_bib' => '22'])
+         ->answers([$ecrivez_des_tests])
+
+
          ->whenCalled('filterByLocaleAndWorkflow')
          ->with([$ecrivez_des_tests])
          ->answers([$ecrivez_des_tests]);
@@ -179,6 +189,7 @@ class BibControllerZoneViewOneWithHideNewsTest extends BibControllerWithZoneTest
 }
 
 
+
 class BibControllerIndexWithHideNewsTest extends BibControllerWithZoneTestCase {
   public function setUp() {
     parent::setUp();
@@ -531,6 +542,25 @@ class BibControllerBibViewAnnecyTest extends BibControllerBibViewTestCase {
 
 
 
+class BibControllerBibViewAnnecyHideNewsTest extends BibControllerBibViewTestCase {
+  public function setUp() {
+    parent::setUp();
+    Class_Profil::getCurrentProfil()
+      ->setModulePreference('bib', 'bibview', 'hide_news', 1);
+
+    $this->dispatch('bib/bibview/id/4', true);
+  }
+
+
+  /** @test */
+  public function articleEcrivezDesTestsShouldNotBeVisible() {
+    $this->assertNotXPathContentContains('//article//header//a[contains(@href, "/cms/articleview/id/2")]',
+                                         'Ecrivez des tests !');
+  }
+}
+
+
+
 class BibControllerBibViewAnnecyRangeOpeningsTest extends BibControllerBibViewTestCase {
   public function setUp() {
     parent::setUp();