hackfest domain selector in search widget : wrap selector in div + fix label for

library/ZendAfi/View/Helper/TagRechercheSimple.php

@@ -189,15 +189,15 @@ class ZendAfi_View_Helper_TagRechercheSimple extends Zend_View_Helper_HtmlElemen
 
   protected function _renderDomainSelectAsSelect($domains) {
     $domains = [0 => $this->view->_('Partout')] + $domains;
-    return $this->view->tag('label',
-                            $this->view->_('Rechercher dans le domaine')
-                            .
-                            $this->view->formSelect(
-                                                    'facettes',
-                                                    0,
-                                                    [],
-                                                    $domains),
-                            ['for' => 'id_catalogue']);
+    return $this->view->tag('div',
+                            $this->view->tag('label',
+                                             $this->view->_('Rechercher dans le domaine'),
+                                             ['for' => 'facettes'])
+                            . $this->view->formSelect(
+                                                      'facettes',
+                                                      0,
+                                                      [],
+                                                      $domains));
   }
 
 

tests/library/ZendAfi/View/Helper/TagRechercheSimpleTest.php

@@ -113,6 +113,16 @@ class ZendAfi_View_Helper_TagRechercheSimpleDefaultTest extends ViewHelperTestCa
   }
 
 
+  /**
+   * @depends withDomainSelectInputShouldBePresent
+   * @test
+   */
+  public function domainSelectLabelShouldBePrensent($html) {
+    $this->assertXPath($html,
+                       '//div/label[@for="facettes"][following-sibling::select[@name="facettes"]/option[1][@value="0"][@selected="selected"]]');
+  }
+
+
   /**
    * @depends withDomainSelectInputShouldBePresent
    * @test