dev #15527 refacto location for item cote test

library/Class/Localisation.php

@@ -236,14 +236,18 @@ class Class_Localisation extends Storm_Model_Abstract {
 											 'section' => $this->getSection(),
 											 'emplacement' => $this->getEmplacement()];
 
-		if(0 == count(array_diff_assoc(array_filter($matching_datas), array_filter($exemplaire_datas))))
+		if(!$matching_datas = array_filter($matching_datas)) {
+			return '';
+		}
+
+		if(!array_filter(array_diff_assoc($matching_datas, $exemplaire_datas)))
 			return $this;
 		return '';
 	}
 
 
 	protected function findLocalisationByCote($exemplaire) {
-		if(($this->hasCoteDebut() and substr($exemplaire->getCote(),0,strlen($this->getCoteDebut())) < $this->getCoteDebut()) || ($this->hasCoteFin() and substr($exemplaire->getCote,0,strlen($this->getCoteFin())) > $this->getCoteFin()))
+		if(($this->hasCoteDebut() and substr($exemplaire->getCote() ,0,strlen($this->getCoteDebut())) >= $this->getCoteDebut()) && ($this->hasCoteFin() and substr($exemplaire->getCote() ,0,strlen($this->getCoteFin())) <= $this->getCoteFin()))
 			return $this;
 
 		return '';

tests/application/modules/opac/controllers/NoticeAjaxControllerTest.php

@@ -1522,4 +1522,37 @@ class NoticeAjaxControllerWithMultipleSelectorLocalisationTest extends NoticeAja
 		$this->assertEquals('Second floor', $this->_json->libelle);
 	}
 }
+
+
+
+class NoticeAjaxControllerLocalisationWithCoteTest extends  NoticeAjaxControllerLocalisationTestCase {
+	public function setUp() {
+		parent::setUp();
+		$this->fixture('Class_Exemplaire',
+									 ['id' => 5,
+										'id_bib' => 1,
+										'code_barres' => '123456',
+										'cote' => '995 E',
+										'genre' => 'Doc',
+										'emplacement' => '7',
+										'id_notice' => 1,
+										'section' => '']);
+
+		Class_Localisation::find(1)
+			->setLibelle('Last floor')
+			->setGenre('')
+			->setCoteDebut('995 A')
+			->setCoteFin('999 Z')
+			->save();
+
+		$this->dispatch('noticeajax/localisation/id_bib/1/cote_barres/123456', true);
+		$this->_json = json_decode($this->_response->getBody());
+	}
+
+
+	/** @test */
+	public function locationTitleShouldBeLastFloor() {
+		$this->assertEquals('Last floor', $this->_json->libelle);
+	}
+}
 ?>
\ No newline at end of file