rel #18020 : RT

application/modules/push/controllers/MultimediaController.php

@@ -81,7 +81,6 @@ class Push_MultimediaController extends Zend_Controller_Action {
 	}
 
 
-
 	public function getAllBorrowersAction() {
 		$this->getHelper('ViewRenderer')->setNoRender();
 
@@ -94,6 +93,7 @@ class Push_MultimediaController extends Zend_Controller_Action {
 			->getResponse($this->_request));
 	}
 
+
 	public function createBorrowerAction() {
 		$multimedia = Class_Multimedia::getInstance();
 		$log = $multimedia->getLog();
@@ -119,11 +119,9 @@ class Push_MultimediaController extends Zend_Controller_Action {
 		if (!$multimedia->isValidHash($sign, $this->_getParam('json'))) {
 			$log->err('Sign check failure');
 			return;
-			}
+		}
 
 		$this->_response->setBody(Class_Multimedia_Users::getInstance()->createUser($infoUser));
-
-
 	}
 }
 ?>
\ No newline at end of file

library/Class/Multimedia/Users.php

@@ -28,16 +28,14 @@ class Class_Multimedia_Users {
 		return self::$_instance;
 	}
 
+
 	public function createUser($infoUsers){
 		foreach($infoUsers as $infoUser) {
-			if(!$this->isValidInfo($infoUser)){
+			if(!$this->isValidInfo($infoUser))
 				return 'INVALID_INFO_USER';
-			}
 
-			if(!$group = Class_UserGroup::findGroupUserMultimedia()){
+			if(!$group = Class_UserGroup::findGroupUserMultimedia())
 				return 'UNDEFINED_GROUP_USER_AFIM';
-			}
-
 
 			$user = new Class_Users();
 			$user->setLogin($infoUser->login)
@@ -66,12 +64,9 @@ class Class_Multimedia_Users {
 
 
 	public function isValidInfo($infoUser){
-		if($infoUser->login != null && $infoUser->login != '' &&
-			 $infoUser->pwd != null && $infoUser->pwd != '' &&
-			 $infoUser->nom != null && $infoUser->nom != '')
-			return true;
-
-		return false;
+		return $infoUser->login != null && $infoUser->login != ''
+			&& $infoUser->pwd != null && $infoUser->pwd != ''
+			&& $infoUser->nom != null && $infoUser->nom != '';
 	}
 
 }

library/Class/UserGroup.php

@@ -138,7 +138,7 @@ class Class_UserGroup extends Storm_Model_Abstract {
 	}
 
 	public static function findGroupUserMultimedia(){
-		return self::findFirstBy(['group_type'=>self::TYPE_MULTIMEDIA]);
+		return self::findFirstBy(['group_type' => self::TYPE_MULTIMEDIA]);
 	}