Dev#163369 : RT fixes follow-up (2)

library/digital_resources/Cvs2/Harvester.php

@@ -27,7 +27,7 @@ class Cvs2_Harvester extends Class_DigitalResource_Harvester_XML {
     $_date_from;
 
 
-  public function __construct(string $catalogue, string $date_from = '1970-01-01') {
+  public function __construct(string $catalogue, string $date_from = '') {
     parent::__construct();
 
     $this->_catalogue = $catalogue;

library/digital_resources/Cvs2/Service.php

@@ -135,7 +135,9 @@ class Cvs2_Service extends Class_DigitalResource_Service {
   protected function _getLastRunOrDefault(){
     $lastdate = '1970-01-01';
 
-    if (($batch = Class_Batch::findFirstBy(['type' => 'Cvs2_Batch'])) && $batch->getLastRun())
+    if (($batch = Class_Batch::findFirstBy(['type' => 'Cvs2_Batch']))
+        && $batch->getLastRun()
+        && $batch->getLastRun() != '0000-00-00 00:00:00')
       $lastdate = $batch->getLastRun();
 
     return $lastdate;

library/digital_resources/Cvs2/Service/Catalogue.php

@@ -29,13 +29,13 @@ class Cvs2_Service_Catalogue extends Cvs2_Service {
   protected string $_response;
 
 
-  public function __construct(string $cataloguename = 'tout', string $from = '1970-01-01'){
+  public function __construct(string $cataloguename = 'tout', string $from = ''){
     parent::__construct(Cvs2_Config::getInstance());
     $this->_harvesting = true;
     $this->_catalogue = $cataloguename;
-    $this->_from = $this->getCurrentDate()
-      ? $this->getCurrentDate()
-      : $from;
+    $this->_from = $from
+      ? $from
+      : $this->getCurrentDate();
     $this->_page = 1;
     $this->_number_per_page = 100;
   }
@@ -53,14 +53,6 @@ class Cvs2_Service_Catalogue extends Cvs2_Service {
   }
 
 
-  public function setFrom(string $from = '' ):self {
-    $this->_from = $from
-      ? $from
-      : $this->getCurrentDate();
-    return $this;
-  }
-
-
   public function setResponse(string $xml ):self {
     $this->_response = $xml;
     return $this;