Merge branch 'hotline#137145_doublons_avis_lecteurs' into 'hotline'

hotline : #137145 : duplicated notice review

See merge request !4292

VERSIONS_HOTLINE/137145

+ - ticket #137145 : Avis : ne plus afficher d'avis en doublons
\ No newline at end of file

library/templates/Intonation/Library/View/Wrapper/Abstract.php

@@ -173,6 +173,11 @@ abstract class Intonation_Library_View_Wrapper_Abstract {
   }
 
 
+  public function updateWithModel($model) {
+    return $this;
+  }
+
+
   protected function _truncate($text) {
     $number_of_word = $this->_widget_context
       ? $this->_widget_context->getDescriptionLength()

library/templates/Intonation/Library/View/Wrapper/ReviewsByRecord.php

@@ -27,19 +27,26 @@ class Intonation_Library_View_Wrapper_ReviewsByRecord extends Intonation_Library
 
 
   public function setModel($model) {
-    if ( ! $model)
-      return parent::setModel($model);
+    $this->updateWithModel($model);
+    return parent::setModel($model);;
+  }
+
+
+  public function updateWithModel($model) {
+    if (!$model)
+      return $this;
 
     $this->_record = (new Intonation_Library_View_Wrapper_Record)
       ->setView($this->_view)
       ->setModel($model->getRecord());
 
+    $this->_reviews = [];
     foreach ($model->getReviews() as $review)
       $this->_reviews [] = (new Intonation_Library_View_Wrapper_ReviewInRecord)
-      ->setView($this->_view)
-      ->setModel($review);
+        ->setView($this->_view)
+        ->setModel($review);
 
-    return parent::setModel($model);
+    return $this;
   }
 
 
@@ -185,4 +192,4 @@ class Intonation_Library_View_Wrapper_ReviewsByRecord extends Intonation_Library
       ->setRecord($record)
       ->setReviews($reviews);
   }
-}
\ No newline at end of file
+}

library/templates/Intonation/View/RenderAjaxPaginatedList.php

@@ -37,7 +37,7 @@ class Intonation_View_RenderAjaxPaginatedList extends ZendAfi_View_Helper_BaseHe
       ? $callback
       : function($element) use ($helper) {
       $element->setView($this->view);
-      $element->setModel($element->getModel());
+      $element->updateWithModel($element->getModel());
       return call_user_func_array([$this->view, $helper->getRendering()], [$element]);
     };
 

tests/scenarios/Templates/TemplatesWidgetCarouselTest.php

@@ -220,3 +220,63 @@ class TemplatesWidgetCarouselRecordNewsTest extends AbstractControllerTestCase {
                         $this->_response->getBody());
   }
 }
+
+
+
+
+/* hotline : #137145 */
+class TemplatesWidgetCarouselNoticeReviewTest
+  extends AbstractControllerTestCase {
+
+  protected $_storm_default_to_volatile = true;
+
+  public function setUp() {
+    parent::setUp();
+
+    $this->fixture(Class_Users::class,
+                   ['id' => 1,
+                    'password' => 'pass',
+                    'login' => 'totoro'
+                   ]);
+
+    for ($i = 2; $i < 27; $i++) {
+      $this->fixture(Class_Notice::class,
+                     ['id' => $i,
+                     ]);
+      $this->fixture(Class_AvisNotice::class,
+                     ['id' => $i + 1,
+                      'id_notice' => $i,
+                      'entete' => 'Avis roman ' . $i,
+                      'avis' => 'Roman de cape et d\'épée ' . $i,
+                      'id_user' => 1
+                     ]);
+    }
+
+    $this->_buildTemplateProfil(['id' => 1,
+                                 'libelle' => 'Carousel Avis Notices'])
+         ->setBoiteOfTypeInDivision(2,
+                                    Intonation_Library_Widget_Carousel_Review_Definition::CODE,
+                                    [
+                                     'layout' => Intonation_Library_Widget_Carousel_Definition::LISTING_WITH_OPTIONS,
+                                     'rendering' => 'card-horizontal',
+                                     'size' => 1000,
+                                     'rss' => 0,
+                                     'embeded-code' => 0,
+                                     'link-to-all' => 1,
+                                     'all-layout' => 'list_with_options',
+                                     'all-rendering' => 'card-horizontal',
+                                     'description-length' => 20,
+                                     'titre' => 'Avis et commentaires',
+                                     'order' => 'review_date'
+                                    ])
+         ->assertSave();
+
+    $this->dispatch('/index');
+  }
+
+
+  /** @test */
+  public function romanDeCapeEtEpee3ShouldNotBeDuplicated() {
+    $this->assertXpathCount('//p[@class="model_description_Class_AvisNotice"][text()="Roman de cape et d\'épée 3"]', 1);
+  }
+}