Merge branch 'hotline#158085_nouveau_soucis_d_exemplaires' into 'master'

hotline #158085 : fix php error when filtering items of record

See merge request !4482

VERSIONS_HOTLINE/158085

+ - correctif #158085 : Magasin de thèmes : correction de la liste d'exemplaires vides pouvant survenir lorsque les données du profil courant sont filtrées
\ No newline at end of file

library/templates/Intonation/Library/Record.php

@@ -73,10 +73,9 @@ class Intonation_Library_Record {
 
 
   public function getUrl() {
-    if (!$items = $this->getItemsFromSIGB())
-      return null;
-
-    return $items[0]->getExternalUrl();
+    return ($items = $this->getItemsFromSIGB())
+      ? reset($items)->getExternalUrl()
+      : null;
   }
 
 

tests/scenarios/Templates/TemplatesSearchItemsTest.php

@@ -37,6 +37,10 @@ abstract class TemplatesTestSearchItemsTestCase
                    ['id' => 1,
                     'libelle' => 'Jeunesse']);
 
+    $this->fixture(Class_CodifSection::class,
+                   ['id' => 2,
+                    'libelle' => 'Moins jeune']);
+
     $this->fixture(Class_CodifEmplacement::class,
                    ['id' => 1,
                     'libelle' => 'Coins petits',
@@ -101,6 +105,43 @@ abstract class TemplatesTestSearchItemsTestCase
 
 
 
+class TemplatesSearchItemsProfilFilterdOnSection extends TemplatesTestSearchItemsTestCase {
+  /** @test */
+  public function pageShouldContainsOneItemOnly() {
+    $exemplaire = $this
+      ->fixture(Class_Exemplaire::class,
+                ['id' => 3,
+                 'code_barres' => '123PS',
+                 'id_bib' => 23,
+                 'int_bib' => Class_IntBib::find(23),
+                 'section' => 2,
+                 'emplacement' => 1,
+                 'zone995' => serialize([
+                                         ['code' => 'a',
+                                          'valeur' => '200022200188'],
+                                         ['code' => 'v',
+                                          'valeur' => 'Mois de Mai Juin'],
+                                         ['code' => 'b',
+                                          'valeur' => 'EMPL1']
+                                         ]),
+                 'sigb_exemplaire' => ((new Class_WebService_SIGB_Exemplaire(13))
+                                       ->beReservable()
+                                       ->setDisponibiliteEnPret()
+                                       ->setDateRetour('2020-01-20')
+                                       ->setNbReservations(3))]);
+
+    Class_Notice::find(456)->addExemplaire($exemplaire);
+
+    Class_Profil::getCurrentProfil()->setSelSection('2');
+
+    $this->dispatch('/opac/noticeajax/resources/id/456');
+    $this->assertXPathCount('//div[contains(@class, "card_body card_body_Intonation_Library_View_Wrapper_Item")]', 1);
+  }
+}
+
+
+
+
 class TemplatesSearchItemsViewNoticeInSectionDocumentItemsTest
   extends TemplatesTestSearchItemsTestCase  {