Skip to content
Snippets Groups Projects

hotline #74120 fix doc type selector in search widget

2 unresolved threads

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Patrick Barroca
    Patrick Barroca @pbarroca started a thread on the diff
    385 $this->preferences['message'] = '';
    386 $this->preferences['placeholder'] = '';
    387 $this->preferences['largeur'] = '';
    388 $this->preferences['exemple'] = '';
    389 $this->preferences['select_annexe'] = '';
    390 $this->preferences['domain_ids'] = '';
    391 $this->preferences['select_bib'] = '';
    392 $this->preferences['recherche_avancee'] = '';
    393 }
    394
    395
    396 /** @test */
    397 public function tousShouldBeSelected() {
    398 $this->preferences['type_doc'] = '';
    399 $this->_html = $this->_helper->tagRechercheSimple($this->preferences, 1);
    400 $this->assertXPathContentContains($this->_html, '//option[@value=""][@selected]', 'tous');
    • Test insuffisant le bug rencontré montre que dans ce cas l'option[@value=""] est bien selected mais que le problème est que l'option[@value="0"] est aussi selected. On doit donc assert que l'option[@value="0"] n'est pas selected.

    • Please register or sign in to reply
  • Patrick Barroca
    Patrick Barroca @pbarroca started a thread on the diff
    401 }
    402
    403
    404 /** @test */
    405 public function livresShouldBeSelected() {
    406 $this->preferences['type_doc'] = '1';
    407 $this->_html = $this->_helper->tagRechercheSimple($this->preferences, 1);
    408 $this->assertXPathContentContains($this->_html, '//option[@value="1"][@selected]', 'Livres');
    409 }
    410
    411
    412 /** @test */
    413 public function nonIdentifieShouldBeSelected() {
    414 $this->preferences['type_doc'] = '0';
    415 $this->_html = $this->_helper->tagRechercheSimple($this->preferences, 1);
    416 $this->assertXPathContentContains($this->_html, '//option[@value="0"][@selected]', 'Non identifi');
    • Test insuffisant le bug rencontré montre que dans ce cas l'option[@value="0"] est bien selected mais que le problème est que l'option[@value=""] est aussi selected. On doit donc assert que l'option[@value=""] n'est pas selected.

    • Please register or sign in to reply
  • Ghislain Loas added 1 commit

    added 1 commit

    • 1395a020 - hotline #74120 fix rt comments

    Compare with previous version

  • Ghislain Loas enabled an automatic merge when the pipeline for 1395a020 succeeds

    enabled an automatic merge when the pipeline for 1395a020 succeeds

  • Ghislain Loas added 1 commit

    added 1 commit

    • 8166584f - hotline #74120 fix failure + warning

    Compare with previous version

  • merged

  • Ghislain Loas mentioned in commit 83164fc7

    mentioned in commit 83164fc7

Please register or sign in to reply