[RTKO] dev#215567 : RGAA/WCAG : Content structure with roles
10 unresolved threads
Merge request reports
Activity
Filter activity
assigned to @afihdlaurent
added 9 commits
-
6c260fb0...04dec6ca - 8 commits from branch
master
- ca98b57c - dev#215567 : RGAA/WCAG : Content structure with roles
-
6c260fb0...04dec6ca - 8 commits from branch
- FEATURES/215567 0 → 100644
1 '215567' => 2 ['Label' => $this->_('[1 pt] Critère 12.6 : Regroupement de contenu'), 3 'Desc' => '', 4 'Image' => '', 5 'Video' => '', 6 'Category' => '', 7 'Right' => function($feature_description, $user) {return true;}, 8 'Wiki' => '', 9 'Test' => '', 10 'Date' => '2025-01-14'], - VERSIONS_WIP/215567 0 → 100644
85 85 86 86 $hide_when_empty = $hidden ? ' widget_hide_empty' : ''; 87 87 88 $attribs = ['id' => 'boite_' . $this->_widget->getIdForHtml(), 89 'class' => sprintf('boite %s %s%s%s', 90 $this->_getClasses(), 91 $this->_widget->wrapperClasses(), 92 $d_none, 93 $hide_when_empty)]; 94 if ($this->_view_helper instanceOf Intonation_Library_Widget_Search_View) 95 $attribs['role'] = 'search'; 34 34 . $this->renderDraftStatus($article) 35 35 . $this->renderArticleInfo($article) 36 36 . $this->tagArticleEvent($article) 37 . $this->renderEventPeriod($article)) 37 . $this->renderEventPeriod($article), 38 ['role' => 'banner'] ) 43 44 .$this->renderICalLink($article) 44 45 .$this->renderPrintLink($article) 45 46 .$this->renderReseauxSociaux($article) 46 .$this->renderAvis($article)) 47 .$this->renderAvis($article), 48 ['role' => 'contentinfo']) doublon de footer d'après la doc .
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/contentinfo_role
requested review from @gloas
29 29 public function getWrappingTag() { 30 30 return 'footer'; 31 31 } 32 33 34 public function getHtmlAttribs() 35 { 36 return array_merge(['role' => 'contentinfo'], parent::getHtmlAttribs()); Doublon du tag footer.
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/contentinfo_role
Il y a aussi duplication de l'array_merge.
Il faut faire l'array_merge une seule fois et demander à la section son role attribs qui retourne tableau vide si elle en a pas.
Edited by Ghislain Loas
29 29 public function getWrappingTag() { 30 30 return 'header'; 31 31 } 32 33 34 public function getHtmlAttribs() 35 { 36 return array_merge(['role' => 'banner'], parent::getHtmlAttribs()); dupli cf !5134 (comment 43102)
43 44 45 public function getHtmlAttribs() 46 { 47 return array_merge(['role' => 'main'], parent::getHtmlAttribs()); dupli cf !5134 (comment 43102)
43 { 44 $this->assertXPath('//nav[@role="navigation"]'); 45 } 46 47 48 /** @test */ 49 public function mainRoleShouldBeMain() 50 { 51 $this->assertXPath('//main[@role="main"]'); 52 } 53 54 55 /** @test */ 56 public function footerRoleShouldBeContentinfo() 57 { 58 $this->assertXPath('//footer[@role="contentinfo"]'); Attention c'est faux.
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/contentinfo_roleè
Faire l'erreur que dans le skin EtatFrancais.