Skip to content
Snippets Groups Projects

[RTKO] hotline#213660 : fix marc file checking page

Open [RTKO] hotline#213660 : fix marc file checking page
hotline#213660_analyser_un_fichier_unimarc_plus_de_resultat into master
3 unresolved threads
Open Alex Arnaud requested to merge hotline#213660_analyser_un_fichier_unimarc_plus_de_resultat into master
3 unresolved threads

Merge request reports

Pipeline #46778 passed

Stage:

    Pipeline passed for 211d02f2 on hotline#213660_analyser_un_fichier_unimarc_plus_de_resultat

    Approval is optional
    Ready to merge by members who can write to the target branch.

    Merge details

    • The source branch is 101 commits behind the target branch.
    • 1 commit and 1 merge commit will be added to master (squashes 2 commits).
    • Source branch will be deleted.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    • Alex Arnaud changed title from Draft: hotline#213660 : fix marc file checking page to Draft: [Blocked poker COSMOZEND] hotline#213660 : fix marc file checking page

      changed title from Draft: hotline#213660 : fix marc file checking page to Draft: [Blocked poker COSMOZEND] hotline#213660 : fix marc file checking page

    • Alex Arnaud
      Alex Arnaud @aarnaud ·
      Author Maintainer

      Supprimer la méthode getDataArticlePeriodique dans classe_notice_integration.php. C'est du code mort Dans la méthode getAuteurs mettre une propriété pour le cache pour pas réinstancier class_Notice_Authors Et refacto

    • Alex Arnaud marked this merge request as ready

      marked this merge request as ready

    • Alex Arnaud changed title from Draft: [Blocked poker COSMOZEND] hotline#213660 : fix marc file checking page to hotline#213660 : fix marc file checking page

      changed title from Draft: [Blocked poker COSMOZEND] hotline#213660 : fix marc file checking page to hotline#213660 : fix marc file checking page

    • Alex Arnaud marked this merge request as draft

      marked this merge request as draft

    • Alex Arnaud added 1 commit

      added 1 commit

      Compare with previous version

    • Alex Arnaud marked this merge request as ready

      marked this merge request as ready

    • Ghislain Loas
      Ghislain Loas @gloas started a thread on the diff
      cosmogramme/php/classes/classe_unimarc.php
      58 58 protected $_id_bib; // Bibliotheque d'intégration
      59 59 protected $_fluent; // Class_NoticeUnimarc_Fluent
      60 60 protected $_type_doc; //type do document
      61 protected $_notice_authors;
      • Ghislain Loas
        Ghislain Loas @gloas ·
        Owner

        Ajouter le suffix _cache.

        Attention aussi à l'usage de l'instance de classe_unimarc car si l'instance est stocké sans jamais être reset, les fonctions qui utilisent cette variable ne pourront plus renvoyer autre chose.

        Edited by Ghislain Loas
      • Please register or sign in to reply
      • Ghislain Loas
        Ghislain Loas @gloas ·
        Owner

        Il n'y a pas de test car code legacy.

        Est-ce qu'on peut pas refaire un tour dans un poker pour refaire cette feature en cosmozend ? La feature me semble vraiment basique.

      • Please register or sign in to reply
    • Ghislain Loas changed title from hotline#213660 : fix marc file checking page to [RTKO] hotline#213660 : fix marc file checking page

      changed title from hotline#213660 : fix marc file checking page to [RTKO] hotline#213660 : fix marc file checking page

    • Ghislain Loas requested review from @gloas

      requested review from @gloas

    Please register or sign in to reply