hotline #74120 fix rt comments

library/ZendAfi/View/Helper/ComboCodification.php

@@ -24,7 +24,7 @@ class ZendAfi_View_Helper_ComboCodification extends ZendAfi_View_Helper_BaseHelp
   const SECTION = 'section';
 
   public function ComboCodification($type, $valeur_select, $events = '') {
-    if(!$valeur_select)
+    if(null === $valeur_select)
       $valeur_select = [];
 
     if(!is_array($valeur_select))
@@ -64,7 +64,7 @@ class ZendAfi_View_Helper_ComboCodification extends ZendAfi_View_Helper_BaseHelp
     $combo = '<select id="' . $id . '" name="' . $name . '"' . $events . ' class="typeDoc">';
 
     foreach ($items as $item) {
-      $selected = $item['value'] == reset($valeur_select) ? ' selected="selected"': '';
+      $selected = $item['value'] === reset($valeur_select) ? ' selected="selected"': '';
       $combo .= '<option value="' . $item["value"] . '"' . $selected.'>' . stripSlashes($item["libelle"]) . '</option>';
     }
     $combo .= '</select>';

tests/library/ZendAfi/View/Helper/TagRechercheSimpleTest.php

@@ -398,6 +398,7 @@ class ZendAfi_View_Helper_TagRechercheSimpleDocTypeTest extends ZendAfi_View_Hel
     $this->preferences['type_doc'] = '';
     $this->_html = $this->_helper->tagRechercheSimple($this->preferences, 1);
     $this->assertXPathContentContains($this->_html, '//option[@value=""][@selected]', 'tous');
+    $this->assertXPathContentContains($this->_html, '//option[@value="0"][not(@selected)]', 'Non identifi');
   }
 
 
@@ -414,5 +415,6 @@ class ZendAfi_View_Helper_TagRechercheSimpleDocTypeTest extends ZendAfi_View_Hel
     $this->preferences['type_doc'] = '0';
     $this->_html = $this->_helper->tagRechercheSimple($this->preferences, 1);
     $this->assertXPathContentContains($this->_html, '//option[@value="0"][@selected]', 'Non identifi');
+    $this->assertXPathContentContains($this->_html, '//option[@value=""][not(@selected)]', 'tous');
   }
 }
\ No newline at end of file