dev dilicomn pnb

fix call on null behavior

library/Class/Album/UsageConstraints.php

@@ -22,7 +22,16 @@
 
 class Class_Album_UsageConstraints extends Storm_Model_Collection_Abstract {
 	public function getLoanConstraint() {
-		return $this->detect(function($c) {return $c->isLoanConstraint();});
+		return ($constraint = $this->detect(function($c) {return $c->isLoanConstraint();}))
+			? $constraint
+			: new Class_Album_UsageConstraint();
+	}
+
+
+	public function getAvailabilityConstraint() {
+		return ($constraint = $this->detect(function($c) {return $c->isAvailabilityConstraint();}))
+			? $constraint
+			: new Class_Album_UsageConstraint();
 	}
 
 
@@ -52,17 +61,17 @@ class Class_Album_UsageConstraints extends Storm_Model_Collection_Abstract {
 
 
 	public function getAvailabilityDuration() {
-		return $this->detect(function($c) {return $c->isAvailabilityConstraint();})->getDuration();
+		return $this->getAvailabilityConstraint()->getDuration();
 	}
 
 
 	public function getAvailabilityEndDate() {
-		return $this->detect(function($c) {return $c->isAvailabilityConstraint();})->getEndDate();
+		return $this->getAvailabilityConstraint()->getEndDate();
 	}
 
 
 	public function isAValidOffer() {
-		return $this->detect(function($c) {return $c->isAvailabilityConstraint();})->isAValidOffer();
+		return $this->getAvailabilityConstraint()->isAValidOffer();
 	}
 
 

tests/library/Class/WebService/Dilicom/PNBOffersParserTest.php

@@ -214,6 +214,25 @@ class DilicomPNBOfferParserTest extends Storm_Test_ModelTestCase {
 	}
 
 
-}
 
+	/**
+	 * @depends firstAlbumShouldBePlusJamaisSansElle
+	 * @test
+	 */
+	public function removeUsageConstraintsAndAskForLoanQuantityShouldAnswers0($album) {
+		$album->setUsageConstraints(new Class_Album_UsageConstraints());
+		$this->assertEquals(0, $album->getUsageConstraints()->getLoanQuantity());
+	}
+
+
+	/**
+	 * @depends firstAlbumShouldBePlusJamaisSansElle
+	 * @test
+	 */
+	public function removeUsageConstraintsAndAskForValidityOfferShouldReturnFalse($album) {
+		$album->setUsageConstraints(new Class_Album_UsageConstraints());
+		$this->assertFalse($album->getUsageConstraints()->isAValidOffer());
+	}
+
+}
 ?>
\ No newline at end of file