Skip to content
Snippets Groups Projects

Dev#22657 pnb display user account

Merged Dev#22657 pnb display user account
dev#22657_pnb_display_user_account into WIP
Merged Ghislain Loas requested to merge dev#22657_pnb_display_user_account into WIP

Merge request reports

Approval is optional

Merged by (Apr 30, 2025 1:48am UTC)

Merge details

  • Changes merged into WIP with feb49dc8.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Patrick Barroca
  • efalcy
    efalcy @efalcy started a thread on the diff
    library/Class/Album/UsageConstraints.php
    88
    89 public function numberOfSimultaneousLoansRemaning() {
    90 return $this->getLoanConstraint()->numberOfSimultaneousLoansRemaning();
    91 }
    92
    93
    94 public function updateLoanUsers($count) {
    95 return $this->getLoanConstraint()->updateLoanUsers($count);
    96 }
    97
    98
    99 public function hasAvailableQuantity() {
    100 return $this->getLoanConstraint()->hasAvailableQuantity();
    101 }
    102
    103
    • efalcy
      efalcy @efalcy ·
      Owner

      $this->getLoanConstraint() ne renvoie jamais nul? il faudrait peut-etre extraire : $this->detect(function($c) {return $c->isAvailabilityConstraint();}) dans une méthode (utilisé au moins 3 fois) ? Et cette closure ne renvoie jamais nul?

Please register or sign in to reply